Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat content wide search #440

Merged
merged 23 commits into from
Jun 25, 2024
Merged

Feat content wide search #440

merged 23 commits into from
Jun 25, 2024

Conversation

ShubhamMewara
Copy link
Contributor

@ShubhamMewara ShubhamMewara commented May 19, 2024

PR Fixes: #175

reopen #294
update: Removed Algolia ( keyword search )
Added vector search using:

search.2.mp4

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

Copy link
Collaborator

@siinghd siinghd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now this,
Honestly i dont know if we need this much or this advanced search. Current search is not bad tho

apps/web/components/ContentSearch.tsx Outdated Show resolved Hide resolved
if (selectedIndex !== -1) {
event.preventDefault();
const selectedTrack = searchTracks[selectedIndex];
window.open(`/tracks/${selectedTrack?.payload.trackId}/${selectedTrack?.payload.problemId}`, "_blank");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use default nextjs rounting for this instead of window.open?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think opening the problem in a new window would make sense instead of using route.push() to push it in the same window, as what the user is searching for might not be in the first problem he opens.

apps/web/components/ContentSearch.tsx Outdated Show resolved Hide resolved
@siinghd
Copy link
Collaborator

siinghd commented Jun 18, 2024

@hkirat do we need this? i am not convinced about this

@ShubhamMewara
Copy link
Contributor Author

ShubhamMewara commented Jun 19, 2024

@hkirat do we need this? i am not convinced about this

@siinghd He raised issue #175 himself.

@ShubhamMewara
Copy link
Contributor Author

for now this, Honestly i dont know if we need this much or this advanced search. Current search is not bad tho

@siinghd @hkirat
First, I implemented the search with Algolia as Harkirat suggested either Algolia or Elasticsearch. However, since Algolia is not open source and can be expensive, Qdrant is a good open-source alternative that we can host ourselves.

@ShubhamMewara ShubhamMewara requested a review from siinghd June 19, 2024 12:34
@ShubhamMewara ShubhamMewara changed the title Feat search Feat content wide search Jun 22, 2024
@hkirat
Copy link
Collaborator

hkirat commented Jun 24, 2024

/bounty $100

@hkirat
Copy link
Collaborator

hkirat commented Jun 24, 2024

@siinghd

@hkirat
Copy link
Collaborator

hkirat commented Jun 24, 2024

Updated the bounty to $100

@siinghd
Copy link
Collaborator

siinghd commented Jun 24, 2024

On it

@siinghd
Copy link
Collaborator

siinghd commented Jun 25, 2024

@hkirat you will have to update the .env... tested it in local working really good. code looks also good.

merging it, just update the .env and the db stuff

@siinghd siinghd merged commit 01cd863 into code100x:main Jun 25, 2024
1 check failed
@ShubhamMewara ShubhamMewara deleted the feat-search branch August 7, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add content wide search
3 participants