-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat content wide search #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now this,
Honestly i dont know if we need this much or this advanced search. Current search is not bad tho
if (selectedIndex !== -1) { | ||
event.preventDefault(); | ||
const selectedTrack = searchTracks[selectedIndex]; | ||
window.open(`/tracks/${selectedTrack?.payload.trackId}/${selectedTrack?.payload.problemId}`, "_blank"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use default nextjs rounting for this instead of window.open?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think opening the problem in a new window would make sense instead of using route.push()
to push it in the same window, as what the user is searching for might not be in the first problem he opens.
@hkirat do we need this? i am not convinced about this |
@siinghd @hkirat |
/bounty $100 |
Updated the bounty to $100 |
On it |
@hkirat you will have to update the .env... tested it in local working really good. code looks also good. merging it, just update the .env and the db stuff |
PR Fixes: #175
reopen #294
update: Removed Algolia ( keyword search )
Added vector search using:
search.2.mp4
Checklist before requesting a review