Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: when clicked on one of the items of the sort dropdown, it is… #460

Merged
merged 6 commits into from
Aug 17, 2024

Conversation

salimshamim
Copy link
Contributor

@salimshamim salimshamim commented Jun 9, 2024

When clicking on an item, the select value changes so quickly that the popper disappears and the touch event simultaneously clicks the element behind it

PR Fixes:

  • 1 Issue 459

Resolves #[459]

To solve the issue with minimal code change, introduced a delay of 20(twenty) milliseconds. This doesn't seem to hamper UX also fixes the issue

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

Solution is hacky but minimally.
Links to a broader issue

@NailwalLakshay
Copy link

I think rather than adding delay you should have used z-index property

@devsargam
Copy link
Collaborator

LGTM, testing it locally

@devsargam
Copy link
Collaborator

Hey @salimshamim can u fix the conflicts???

@devsargam
Copy link
Collaborator

Gentle remainder @salimshamim if you could fix conflicts

@salimshamim
Copy link
Contributor Author

@devsargam Sorry, it was long time since I PRd it. Conflicts have been resolved.

@salimshamim salimshamim reopened this Aug 12, 2024
Copy link
Collaborator

@devsargam devsargam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits. Looks good

apps/web/components/Tracks.tsx Outdated Show resolved Hide resolved
apps/web/components/Tracks.tsx Outdated Show resolved Hide resolved
@devsargam
Copy link
Collaborator

Thank you @salimshamim for your contribution. I don't think if it deserves a bounty since it's a fairly small change

@devsargam devsargam merged commit 71337fe into code100x:main Aug 17, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants