-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: when clicked on one of the items of the sort dropdown, it is… #460
Conversation
… also clicking the track card beneath it
I think rather than adding delay you should have used z-index property |
LGTM, testing it locally |
Hey @salimshamim can u fix the conflicts??? |
Gentle remainder @salimshamim if you could fix conflicts |
@devsargam Sorry, it was long time since I PRd it. Conflicts have been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits. Looks good
Thank you @salimshamim for your contribution. I don't think if it deserves a bounty since it's a fairly small change |
When clicking on an item, the select value changes so quickly that the popper disappears and the touch event simultaneously clicks the element behind it
PR Fixes:
Resolves #[459]
To solve the issue with minimal code change, introduced a delay of 20(twenty) milliseconds. This doesn't seem to hamper UX also fixes the issue
Checklist before requesting a review
Solution is hacky but minimally.
Links to a broader issue