Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the download-pdf option issue #511

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

zenithexe
Copy link
Contributor

PR Fixes:

  • 1 Makes the PDF page breaks consistent
  • 2 The Images in the generated PDF are well visible
  • 3 The pagination bar in excluded in the generated pdf.

Resolves #494

Before Fix :

  • 1 Some of the images were getting hidden by the new blog-component
    Bug1

  • 2 The pagination was coming include in the pdf
    Bug2

After Fix :

  • 1 The Page breaks were made consistent and Images were visible.
    Fix1

  • 2 The Pagination Component was excluded in the pdf
    Fix2

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@TanmayDhobale
Copy link
Contributor

cool

@devsargam
Copy link
Collaborator

@zenithexe great! But could you reduce the diff?

@zenithexe
Copy link
Contributor Author

@devsargam by "reduce the diff", do you mean to eliminate the unnecessary changes that was caused due to useless line-shift or extra spaces ?

@devsargam
Copy link
Collaborator

Yep

@zenithexe
Copy link
Contributor Author

zenithexe commented Aug 5, 2024

@devsargam Since, I am new to open-source contributing, I am bit confused.
I have eliminated the unnecessary changes in my fork version and pushed it. So, we it be included in this pull request ?

@devsargam
Copy link
Collaborator

@zenithexe the reason why we try to eliminate unnecessary changes is just because I can get to what you did easily.

@zenithexe
Copy link
Contributor Author

@devsargam Okk, I have already eliminated the unnecessary changes... and made a new commit. You can check.

@devsargam
Copy link
Collaborator

Works great locally. Thank you for your contribution. You will receive a bounty if it deserves one.

@devsargam devsargam merged commit de9bf36 into code100x:main Aug 11, 2024
@skodavalla
Copy link

@devsargam no bounty for issue reporting? :-)

@devsargam
Copy link
Collaborator

@skodavalla issue reporting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants