-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed the download-pdf option issue #511
fixed the download-pdf option issue #511
Conversation
cool |
@zenithexe great! But could you reduce the diff? |
@devsargam by "reduce the diff", do you mean to eliminate the unnecessary changes that was caused due to useless line-shift or extra spaces ? |
Yep |
@devsargam Since, I am new to open-source contributing, I am bit confused. |
@zenithexe the reason why we try to eliminate unnecessary changes is just because I can get to what you did easily. |
@devsargam Okk, I have already eliminated the unnecessary changes... and made a new commit. You can check. |
Works great locally. Thank you for your contribution. You will receive a bounty if it deserves one. |
@devsargam no bounty for issue reporting? :-) |
@skodavalla issue reporting? |
PR Fixes:
Resolves #494
Before Fix :
1 Some of the images were getting hidden by the new blog-component
2 The pagination was coming include in the pdf
After Fix :
1 The Page breaks were made consistent and Images were visible.
2 The Pagination Component was excluded in the pdf
Checklist before requesting a review