Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log errors #588

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Log errors #588

wants to merge 4 commits into from

Conversation

Ashutoshpadhi629
Copy link
Contributor

@Ashutoshpadhi629 Ashutoshpadhi629 commented Aug 27, 2024 •
edited
Loading

PR Fixes:

  • fixed the possible log errors
  • fixed the filter button
  • Configured next.config to allow domains used in Image tag in dev mode

Resolves #587 , #590

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@Ashutoshpadhi629
Copy link
Contributor Author

using yarn install and yarn dev instead of npm or changing pipeline to tasks in all turbo.json files will fix this error
Screenshot 2024-08-27 at 6 48 35 PM

@Ashutoshpadhi629 Ashutoshpadhi629 mentioned this pull request Aug 28, 2024
Closed
devsargam
devsargam approved these changes Sep 30, 2024
View reviewed changes
apps/web/next.config.js
images: {
domains: ["d2szwvl7yo497w.cloudfront.net", "appx-wsb-gcp.akamai.net.in"], // Add your domain here
},
images: isDev
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great change

@devsargam
Copy link
Collaborator

can u fix conflicts?

@Ashutoshpadhi629
Copy link
Contributor Author

Ashutoshpadhi629 commented Sep 30, 2024 •
edited
Loading

can u fix conflicts?

done , @devsargam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsargam devsargam devsargam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Few error logs when u run the project locally
2 participants
@Ashutoshpadhi629 @devsargam