Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#609)/added pagination on home page #610

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

toufiqfarhan0
Copy link
Contributor

@toufiqfarhan0 toufiqfarhan0 commented Aug 31, 2024

PR Fixes:

  • Added pagination
  • Implemented Click on Prev and Next

Resolves #609

Pagination.solved.-.Made.with.Clipchamp.1.mp4

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@devsargam
Copy link
Collaborator

The good question to ask is do we need pagination?

I always prefer to use cmd + f when going through daily-code

Also, doing it client side doesn't make much sense to me.

@hkirat can we merge this?

@toufiqfarhan0 can u give more ctx on why we might need it?

@toufiqfarhan0
Copy link
Contributor Author

toufiqfarhan0 commented Sep 1, 2024

The good question to ask is do we need pagination?

I always prefer to use cmd + f when going through daily-code

Also, doing it client side doesn't make much sense to me.

@hkirat can we merge this?

@toufiqfarhan0 can u give more ctx on why we might need it?

@devsargam @hkirat

Context: The reason for adding pagination is that users currently have to scroll all the way to the bottom of the landing page to see all the available slides. Pagination would make it easier for users to navigate through the slides without excessive scrolling.

Yes, you're right cmd + f , but it makes homepage look good.(my thought)

And also there is already pagination present I mean buttons, I just made the buttons(previous, next buttons, pagination) works fine when onclicking. You can check this (Pagination already present).

Explaination.-.Made.with.Clipchamp.mp4

Sorry about the issue name it's bit confusing 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: there is no pagination for slides
2 participants