Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add number of testResultsCount #703

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RulaKhaled
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?
Needed for failed tests UI.

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@RulaKhaled RulaKhaled requested a review from a team as a code owner July 23, 2024 10:44
@codecov-qa
Copy link

codecov-qa bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.63%. Comparing base (ca9dfc8) to head (63662b2).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #703   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         632      632           
  Lines       16868    16873    +5     
=======================================
+ Hits        15457    15462    +5     
  Misses       1411     1411           
Flag Coverage Δ
unit 91.63% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/repository/repository.py 100.00% <100.00%> (ø)
reports/tests/factories.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.63%. Comparing base (ca9dfc8) to head (63662b2).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #703   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         632      632           
  Lines       16868    16873    +5     
=======================================
+ Hits        15457    15462    +5     
  Misses       1411     1411           
Flag Coverage Δ
unit 91.63% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/repository/repository.py 100.00% <100.00%> (ø)
reports/tests/factories.py 100.00% <100.00%> (ø)

Impacted file tree graph

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (ca9dfc8) to head (63662b2).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #703        +/-   ##
================================================
+ Coverage   95.97000   95.98000   +0.01000     
================================================
  Files           812        812                
  Lines         18205      18210         +5     
================================================
+ Hits          17473      17478         +5     
  Misses          732        732                
Flag Coverage Δ
unit 91.63% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 91.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants