Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused core/managers.py #815

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

michelletran-codecov
Copy link
Contributor

@michelletran-codecov michelletran-codecov commented Sep 11, 2024

Purpose/Motivation

This file has been moved to shared, so removing it here.

What does this PR do?

Clean up unused file.

Notes to Reviewer

File in shared: https://github.com/codecov/shared/blob/main/shared/django_apps/core/managers.py

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

This file has been moved to `shared`, so removing it here.
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.22%. Comparing base (f6ed141) to head (887ebc1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #815   +/-   ##
===========================================
  Coverage   96.22000   96.22000           
===========================================
  Files           812        812           
  Lines         18536      18535    -1     
===========================================
  Hits          17836      17836           
+ Misses          700        699    -1     
Flag Coverage Δ
unit 92.45% <ø> (+0.39%) ⬆️
unit-latest-uploader 92.45% <ø> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michelletran-codecov michelletran-codecov marked this pull request as ready for review September 11, 2024 16:08
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@michelletran-codecov michelletran-codecov added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 7959ae8 Sep 11, 2024
19 checks passed
@michelletran-codecov michelletran-codecov deleted the remove_unused_manager branch September 11, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants