[temp] Add additional permissions to pulls and test results endpoint #827
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
===========================================
Coverage 96.23000 96.23000
===========================================
Files 812 812
Lines 18567 18575 +8
===========================================
+ Hits 17868 17876 +8
Misses 699 699
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rohitvinnakota-codecov
changed the title
rohitvinnakota-codecov
changed the title
rohitvinnakota-codecov
changed the title
|
@codecov-ai-reviewer |
|
I've reviewed this Pull Request and have no helpful feedback. |
| def test_no_pull_if_not_super_token_nor_user_token( | ||
| self, repository_artifact_permisssions_has_permission | ||
| ): | ||
| repository_artifact_permisssions_has_permission.return_value = False |
There was a problem hiding this comment.
Just realized there's a typo in permisssions, could you pls change those 🙏
| "pullid": self.pulls[0].pullid, | ||
| }, | ||
| ), | ||
| HTTP_AUTHORIZATION="Bearer testaxs3o76rdcdpfzexuccx3uatui2nw73r", |
There was a problem hiding this comment.
Optional: since this test succeeds because the token must match the SUPER_API_TOKEN, perhaps make a constant MOCK_SUPER_API_TOKEN up top and use it where needed
| self, repository_artifact_permisssions_has_permission | ||
| ): | ||
| repository_artifact_permisssions_has_permission.return_value = False | ||
| res = self.client.post( |
There was a problem hiding this comment.
I also didn't explicitly ask, but you're expecting only GETs to these endpoints right?
There was a problem hiding this comment.
Yeah
| def test_pull_with_valid_super_token( | ||
| self, repository_artifact_permisssions_has_permission | ||
| ): | ||
| repository_artifact_permisssions_has_permission.return_value = False |
There was a problem hiding this comment.
I'm actually curious, I don't think we need this mock here. Could you try getting rid of this and see if the test still passes?
rohitvinnakota-codecov
deleted the
rvinnakota/update-PR-endpoint-perms
branch
Purpose/Motivation
What is the feature? Why is this being done?
This change unblocks some short term workflows between Codecov and Sentry's Seer service. Seer will query Codecov's pulls endpoint for a given PR and use coverage information to generate tests.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.