Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up deprecated graphql fields - repo flags, components #859

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Oct 5, 2024

This PR cleans up the now-deprecated fields in GraphQL queries related to repository flags and components.
API PR that duplicated these fields to new - #842
Gazebo PR that cut over to the new fields - codecov/gazebo#3203

Tested by confirming against staging deploy that no regression in the frontend calls.

Closes codecov/engineering-team#2290

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (af3e62f) to head (a80562b).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
- Coverage   96.33%   96.31%   -0.02%     
==========================================
  Files         823      823              
  Lines       19156    19063      -93     
==========================================
- Hits        18453    18360      -93     
  Misses        703      703              
Flag Coverage Δ
unit 92.65% <100.00%> (-0.04%) ⬇️
unit-latest-uploader 92.65% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Oct 5, 2024

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
2357 6 2351 6
View the top 3 failed tests by shortest run time
graphql_api.tests.test_repository.TestFetchRepository test_repository_components_select_with_search
Stack Traces | 0.365s run time
self = &lt;graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_components_select_with_search&gt;

    def test_repository_components_select_with_search(self):
        repo = RepositoryFactory(
            author=self.owner,
            active=True,
            private=True,
            yaml={
                "component_management": {
                    "default_rules": {},
                    "individual_components": [
                        {
                            "component_id": "blah",
                            "paths": [r".*\.go"],
                            "name": "blah_name",
                        },
                        {"component_id": "cool_rules", "name": "cool_name"},
                    ],
                }
            },
        )
    
&gt;       data = self.gql_request(
            query_repository
            % """
                componentsYaml(termId: "blah") {
                    id
                    name
                }
            """,
            owner=self.owner,
            variables={"name": repo.name},
        )

graphql_api/tests/test_repository.py:721: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = &lt;graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_components_select_with_search&gt;
query = '\nquery Repository($name: String!){\n    me {\n        owner {\n            repository(name: $name) {\n              ...          ... on ResolverError {\n                    message\n                }\n            }\n        }\n    }\n}\n'
provider = 'gh', owner = &lt;Owner: Owner&lt;github/codecov-user&gt;&gt;
variables = {'name': 'gas'}, with_errors = False, okta_signed_in_accounts = []
impersonate_owner = False

    def gql_request(
        self,
        query,
        provider="gh",
        owner=None,
        variables=None,
        with_errors=False,
        okta_signed_in_accounts=[],
        impersonate_owner=False,
    ):
        url = f"/graphql/{provider}"
    
        if owner:
            self.client = Client()
    
            if impersonate_owner:
                staff_owner = OwnerFactory(
                    name="staff_user", service="github", user=UserFactory(is_staff=True)
                )
                self.client.cookies = SimpleCookie({"staff_user": owner.pk})
                self.client.force_login_owner(staff_owner)
            else:
                self.client.force_login_owner(owner)
    
            if okta_signed_in_accounts:
                session = self.client.session
                session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
                session.save()
    
        response = self.client.post(
            url,
            {"query": query, "variables": variables or {}},
            content_type="application/json",
        )
&gt;       return response.json() if with_errors else response.json()["data"]
E       KeyError: 'data'

graphql_api/tests/helper.py:44: KeyError
graphql_api.tests.test_repository.TestFetchRepository test_repository_components_select
Stack Traces | 0.369s run time
self = &lt;graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_components_select&gt;

    def test_repository_components_select(self):
        repo = RepositoryFactory(
            author=self.owner,
            active=True,
            private=True,
            yaml={
                "component_management": {
                    "default_rules": {},
                    "individual_components": [
                        {
                            "component_id": "blah",
                            "paths": [r".*\.go"],
                            "name": "blah_name",
                        },
                        {"component_id": "cool_rules", "name": "cool_name"},
                    ],
                }
            },
        )
    
&gt;       data = self.gql_request(
            query_repository
            % """
                componentsYaml(termId: null) {
                    id
                    name
                }
            """,
            owner=self.owner,
            variables={"name": repo.name},
        )

graphql_api/tests/test_repository.py:684: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = &lt;graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_components_select&gt;
query = '\nquery Repository($name: String!){\n    me {\n        owner {\n            repository(name: $name) {\n              ...          ... on ResolverError {\n                    message\n                }\n            }\n        }\n    }\n}\n'
provider = 'gh', owner = &lt;Owner: Owner&lt;github/codecov-user&gt;&gt;
variables = {'name': 'yeah'}, with_errors = False, okta_signed_in_accounts = []
impersonate_owner = False

    def gql_request(
        self,
        query,
        provider="gh",
        owner=None,
        variables=None,
        with_errors=False,
        okta_signed_in_accounts=[],
        impersonate_owner=False,
    ):
        url = f"/graphql/{provider}"
    
        if owner:
            self.client = Client()
    
            if impersonate_owner:
                staff_owner = OwnerFactory(
                    name="staff_user", service="github", user=UserFactory(is_staff=True)
                )
                self.client.cookies = SimpleCookie({"staff_user": owner.pk})
                self.client.force_login_owner(staff_owner)
            else:
                self.client.force_login_owner(owner)
    
            if okta_signed_in_accounts:
                session = self.client.session
                session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
                session.save()
    
        response = self.client.post(
            url,
            {"query": query, "variables": variables or {}},
            content_type="application/json",
        )
&gt;       return response.json() if with_errors else response.json()["data"]
E       KeyError: 'data'

graphql_api/tests/helper.py:44: KeyError
graphql_api.tests.test_repository.TestFetchRepository test_repository_has_components_count
Stack Traces | 0.37s run time
self = &lt;graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_has_components_count&gt;

    def test_repository_has_components_count(self):
        repo = RepositoryFactory(
            author=self.owner,
            active=True,
            private=True,
            yaml={
                "component_management": {
                    "default_rules": {},
                    "individual_components": [
                        {"component_id": "blah", "paths": [r".*\.go"]},
                        {"component_id": "cool_rules"},
                    ],
                }
            },
        )
    
&gt;       data = self.gql_request(
            query_repository
            % """
                componentsCount
            """,
            owner=self.owner,
            variables={"name": repo.name},
        )

graphql_api/tests/test_repository.py:634: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = &lt;graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_has_components_count&gt;
query = '\nquery Repository($name: String!){\n    me {\n        owner {\n            repository(name: $name) {\n              ...          ... on ResolverError {\n                    message\n                }\n            }\n        }\n    }\n}\n'
provider = 'gh', owner = &lt;Owner: Owner&lt;github/codecov-user&gt;&gt;
variables = {'name': 'employee'}, with_errors = False
okta_signed_in_accounts = [], impersonate_owner = False

    def gql_request(
        self,
        query,
        provider="gh",
        owner=None,
        variables=None,
        with_errors=False,
        okta_signed_in_accounts=[],
        impersonate_owner=False,
    ):
        url = f"/graphql/{provider}"
    
        if owner:
            self.client = Client()
    
            if impersonate_owner:
                staff_owner = OwnerFactory(
                    name="staff_user", service="github", user=UserFactory(is_staff=True)
                )
                self.client.cookies = SimpleCookie({"staff_user": owner.pk})
                self.client.force_login_owner(staff_owner)
            else:
                self.client.force_login_owner(owner)
    
            if okta_signed_in_accounts:
                session = self.client.session
                session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
                session.save()
    
        response = self.client.post(
            url,
            {"query": query, "variables": variables or {}},
            content_type="application/json",
        )
&gt;       return response.json() if with_errors else response.json()["data"]
E       KeyError: 'data'

graphql_api/tests/helper.py:44: KeyError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2363 tests with 6 failed, 2351 passed and 6 skipped.

View the full list of failed tests

pytest

  • Class name: graphql_api.tests.test_repository.TestFetchRepository
    Test name: test_repository_components_metadata

    self = <graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_components_metadata>

    @override_settings(TIMESERIES_ENABLED=False)
    def test_repository_components_metadata(self):
    user = OwnerFactory()
    repo = RepositoryFactory(author=user)
    > data = self.gql_request(
    query_repository
    % """
    componentsMeasurementsActive
    componentsMeasurementsBackfilled
    """,
    owner=user,
    variables={"name": repo.name},
    )

    graphql_api/tests/test_repository.py:372:
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    self = <graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_components_metadata>
    query = '\nquery Repository($name: String!){\n me {\n owner {\n repository(name: $name) {\n ... ... on ResolverError {\n message\n }\n }\n }\n }\n}\n'
    provider = 'gh', owner = <Owner: Owner<github/kevin32>>
    variables = {'name': 'time'}, with_errors = False, okta_signed_in_accounts = []
    impersonate_owner = False

    def gql_request(
    self,
    query,
    provider="gh",
    owner=None,
    variables=None,
    with_errors=False,
    okta_signed_in_accounts=[],
    impersonate_owner=False,
    ):
    url = f"/graphql/{provider}"

    if owner:
    self.client = Client()

    if impersonate_owner:
    staff_owner = OwnerFactory(
    name="staff_user", service="github", user=UserFactory(is_staff=True)
    )
    self.client.cookies = SimpleCookie({"staff_user": owner.pk})
    self.client.force_login_owner(staff_owner)
    else:
    self.client.force_login_owner(owner)

    if okta_signed_in_accounts:
    session = self.client.session
    session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
    session.save()

    response = self.client.post(
    url,
    {"query": query, "variables": variables or {}},
    content_type="application/json",
    )
    > return response.json() if with_errors else response.json()["data"]
    E KeyError: 'data'

    graphql_api/tests/helper.py:44: KeyError
  • Class name: graphql_api.tests.test_repository.TestFetchRepository
    Test name: test_repository_components_select

    self = <graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_components_select>

    def test_repository_components_select(self):
    repo = RepositoryFactory(
    author=self.owner,
    active=True,
    private=True,
    yaml={
    "component_management": {
    "default_rules": {},
    "individual_components": [
    {
    "component_id": "blah",
    "paths": [r".*\.go"],
    "name": "blah_name",
    },
    {"component_id": "cool_rules", "name": "cool_name"},
    ],
    }
    },
    )

    > data = self.gql_request(
    query_repository
    % """
    componentsYaml(termId: null) {
    id
    name
    }
    """,
    owner=self.owner,
    variables={"name": repo.name},
    )

    graphql_api/tests/test_repository.py:684:
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    self = <graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_components_select>
    query = '\nquery Repository($name: String!){\n me {\n owner {\n repository(name: $name) {\n ... ... on ResolverError {\n message\n }\n }\n }\n }\n}\n'
    provider = 'gh', owner = <Owner: Owner<github/codecov-user>>
    variables = {'name': 'yeah'}, with_errors = False, okta_signed_in_accounts = []
    impersonate_owner = False

    def gql_request(
    self,
    query,
    provider="gh",
    owner=None,
    variables=None,
    with_errors=False,
    okta_signed_in_accounts=[],
    impersonate_owner=False,
    ):
    url = f"/graphql/{provider}"

    if owner:
    self.client = Client()

    if impersonate_owner:
    staff_owner = OwnerFactory(
    name="staff_user", service="github", user=UserFactory(is_staff=True)
    )
    self.client.cookies = SimpleCookie({"staff_user": owner.pk})
    self.client.force_login_owner(staff_owner)
    else:
    self.client.force_login_owner(owner)

    if okta_signed_in_accounts:
    session = self.client.session
    session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
    session.save()

    response = self.client.post(
    url,
    {"query": query, "variables": variables or {}},
    content_type="application/json",
    )
    > return response.json() if with_errors else response.json()["data"]
    E KeyError: 'data'

    graphql_api/tests/helper.py:44: KeyError
  • Class name: graphql_api.tests.test_repository.TestFetchRepository
    Test name: test_repository_components_select_with_search

    self = <graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_components_select_with_search>

    def test_repository_components_select_with_search(self):
    repo = RepositoryFactory(
    author=self.owner,
    active=True,
    private=True,
    yaml={
    "component_management": {
    "default_rules": {},
    "individual_components": [
    {
    "component_id": "blah",
    "paths": [r".*\.go"],
    "name": "blah_name",
    },
    {"component_id": "cool_rules", "name": "cool_name"},
    ],
    }
    },
    )

    > data = self.gql_request(
    query_repository
    % """
    componentsYaml(termId: "blah") {
    id
    name
    }
    """,
    owner=self.owner,
    variables={"name": repo.name},
    )

    graphql_api/tests/test_repository.py:721:
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    self = <graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_components_select_with_search>
    query = '\nquery Repository($name: String!){\n me {\n owner {\n repository(name: $name) {\n ... ... on ResolverError {\n message\n }\n }\n }\n }\n}\n'
    provider = 'gh', owner = <Owner: Owner<github/codecov-user>>
    variables = {'name': 'gas'}, with_errors = False, okta_signed_in_accounts = []
    impersonate_owner = False

    def gql_request(
    self,
    query,
    provider="gh",
    owner=None,
    variables=None,
    with_errors=False,
    okta_signed_in_accounts=[],
    impersonate_owner=False,
    ):
    url = f"/graphql/{provider}"

    if owner:
    self.client = Client()

    if impersonate_owner:
    staff_owner = OwnerFactory(
    name="staff_user", service="github", user=UserFactory(is_staff=True)
    )
    self.client.cookies = SimpleCookie({"staff_user": owner.pk})
    self.client.force_login_owner(staff_owner)
    else:
    self.client.force_login_owner(owner)

    if okta_signed_in_accounts:
    session = self.client.session
    session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
    session.save()

    response = self.client.post(
    url,
    {"query": query, "variables": variables or {}},
    content_type="application/json",
    )
    > return response.json() if with_errors else response.json()["data"]
    E KeyError: 'data'

    graphql_api/tests/helper.py:44: KeyError
  • Class name: graphql_api.tests.test_repository.TestFetchRepository
    Test name: test_repository_flags_metadata

    self = <graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_flags_metadata>

    @override_settings(TIMESERIES_ENABLED=False)
    def test_repository_flags_metadata(self):
    user = OwnerFactory()
    repo = RepositoryFactory(author=user)
    > data = self.gql_request(
    query_repository
    % """
    flagsMeasurementsActive
    flagsMeasurementsBackfilled
    """,
    owner=user,
    variables={"name": repo.name},
    )

    graphql_api/tests/test_repository.py:356:
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    self = <graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_flags_metadata>
    query = '\nquery Repository($name: String!){\n me {\n owner {\n repository(name: $name) {\n ... ... on ResolverError {\n message\n }\n }\n }\n }\n}\n'
    provider = 'gh', owner = <Owner: Owner<github/millerjanice>>
    variables = {'name': 'bit'}, with_errors = False, okta_signed_in_accounts = []
    impersonate_owner = False

    def gql_request(
    self,
    query,
    provider="gh",
    owner=None,
    variables=None,
    with_errors=False,
    okta_signed_in_accounts=[],
    impersonate_owner=False,
    ):
    url = f"/graphql/{provider}"

    if owner:
    self.client = Client()

    if impersonate_owner:
    staff_owner = OwnerFactory(
    name="staff_user", service="github", user=UserFactory(is_staff=True)
    )
    self.client.cookies = SimpleCookie({"staff_user": owner.pk})
    self.client.force_login_owner(staff_owner)
    else:
    self.client.force_login_owner(owner)

    if okta_signed_in_accounts:
    session = self.client.session
    session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
    session.save()

    response = self.client.post(
    url,
    {"query": query, "variables": variables or {}},
    content_type="application/json",
    )
    > return response.json() if with_errors else response.json()["data"]
    E KeyError: 'data'

    graphql_api/tests/helper.py:44: KeyError
  • Class name: graphql_api.tests.test_repository.TestFetchRepository
    Test name: test_repository_has_components_count

    self = <graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_has_components_count>

    def test_repository_has_components_count(self):
    repo = RepositoryFactory(
    author=self.owner,
    active=True,
    private=True,
    yaml={
    "component_management": {
    "default_rules": {},
    "individual_components": [
    {"component_id": "blah", "paths": [r".*\.go"]},
    {"component_id": "cool_rules"},
    ],
    }
    },
    )

    > data = self.gql_request(
    query_repository
    % """
    componentsCount
    """,
    owner=self.owner,
    variables={"name": repo.name},
    )

    graphql_api/tests/test_repository.py:634:
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    self = <graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_has_components_count>
    query = '\nquery Repository($name: String!){\n me {\n owner {\n repository(name: $name) {\n ... ... on ResolverError {\n message\n }\n }\n }\n }\n}\n'
    provider = 'gh', owner = <Owner: Owner<github/codecov-user>>
    variables = {'name': 'employee'}, with_errors = False
    okta_signed_in_accounts = [], impersonate_owner = False

    def gql_request(
    self,
    query,
    provider="gh",
    owner=None,
    variables=None,
    with_errors=False,
    okta_signed_in_accounts=[],
    impersonate_owner=False,
    ):
    url = f"/graphql/{provider}"

    if owner:
    self.client = Client()

    if impersonate_owner:
    staff_owner = OwnerFactory(
    name="staff_user", service="github", user=UserFactory(is_staff=True)
    )
    self.client.cookies = SimpleCookie({"staff_user": owner.pk})
    self.client.force_login_owner(staff_owner)
    else:
    self.client.force_login_owner(owner)

    if okta_signed_in_accounts:
    session = self.client.session
    session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
    session.save()

    response = self.client.post(
    url,
    {"query": query, "variables": variables or {}},
    content_type="application/json",
    )
    > return response.json() if with_errors else response.json()["data"]
    E KeyError: 'data'

    graphql_api/tests/helper.py:44: KeyError
  • Class name: graphql_api.tests.test_repository.TestFetchRepository
    Test name: test_repository_no_components_count

    self = <graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_no_components_count>

    def test_repository_no_components_count(self):
    repo = RepositoryFactory(
    author=self.owner,
    active=True,
    private=True,
    yaml={"component_management": {}},
    )

    > data = self.gql_request(
    query_repository
    % """
    componentsCount
    """,
    owner=self.owner,
    variables={"name": repo.name},
    )

    graphql_api/tests/test_repository.py:653:
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    self = <graphql_api.tests.test_repository.TestFetchRepository testMethod=test_repository_no_components_count>
    query = '\nquery Repository($name: String!){\n me {\n owner {\n repository(name: $name) {\n ... ... on ResolverError {\n message\n }\n }\n }\n }\n}\n'
    provider = 'gh', owner = <Owner: Owner<github/codecov-user>>
    variables = {'name': 'piece'}, with_errors = False, okta_signed_in_accounts = []
    impersonate_owner = False

    def gql_request(
    self,
    query,
    provider="gh",
    owner=None,
    variables=None,
    with_errors=False,
    okta_signed_in_accounts=[],
    impersonate_owner=False,
    ):
    url = f"/graphql/{provider}"

    if owner:
    self.client = Client()

    if impersonate_owner:
    staff_owner = OwnerFactory(
    name="staff_user", service="github", user=UserFactory(is_staff=True)
    )
    self.client.cookies = SimpleCookie({"staff_user": owner.pk})
    self.client.force_login_owner(staff_owner)
    else:
    self.client.force_login_owner(owner)

    if okta_signed_in_accounts:
    session = self.client.session
    session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
    session.save()

    response = self.client.post(
    url,
    {"query": query, "variables": variables or {}},
    content_type="application/json",
    )
    > return response.json() if with_errors else response.json()["data"]
    E KeyError: 'data'

    graphql_api/tests/helper.py:44: KeyError

@suejung-sentry suejung-sentry marked this pull request as ready for review October 8, 2024 18:46
@suejung-sentry suejung-sentry requested a review from a team as a code owner October 8, 2024 18:46
Copy link
Contributor Author

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note some of the PR bot comments say tests failed but the latest test runs have passed (e.g., here)

@suejung-sentry suejung-sentry added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 1f6b320 Oct 10, 2024
30 of 32 checks passed
@suejung-sentry suejung-sentry deleted the sshin/2290 branch October 10, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.3] Clean Up Old API Implementation
2 participants