True Tokenless for BA and TA

[nora-codecov]

Purpose/Motivation

TT requires certain identifiers, BA and TA don't have the identifiers in their path, so I make custom methods to get the identifiers so that BA and TA can use TT.

Links to relevant tickets

codecov/engineering-team#2877

[codecov-notifications]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (b62fc87) to head (56f613b).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   96.25%   96.26%           
=======================================
  Files         827      827           
  Lines       19090    19113   +23     
=======================================
+ Hits        18376    18399   +23     
  Misses        714      714           

Flag	Coverage Δ
unit	92.53% <100.00%> (+<0.01%)	⬆️
unit-latest-uploader	92.53% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joseph-sentry]

left a couple of comments on the test results stuff that may also apply to BA

[codecov-public-qa]

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2749 tests with 1 failed, 2742 passed and 6 skipped.

View the full list of failed tests

pytest

• Class name: api.internal.tests.test_charts.TestChartQueryRunnerQuery
  Test name: test_query_aggregates_multiple_repository_totals
  
  

  self = <tests.test_charts.TestChartQueryRunnerQuery testMethod=test_query_aggregates_multiple_repository_totals>
  
      @override_settings(GITHUB_CLIENT_ID="3d44be0e772666136a13")
      def test_query_aggregates_multiple_repository_totals(self):
          query_runner = ChartQueryRunner(
              user=self.user,
              request_params={
                  "owner_username": self.org.username,
                  "service": self.org.service,
                  "end_date": str(timezone.now()),
                  "grouping_unit": "day",
              },
          )
      
          results = query_runner.run_query()
      
          assert len(results) == 1
  >       assert results[0]["total_hits"] == 114
  E       AssertionError: assert Decimal('14') == 114
  
  .../internal/tests/test_charts.py:564: AssertionError

[codecov-qa]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
2743	1	2742	6

View the top 1 failed tests by shortest run time

api.internal.tests.test_charts.TestChartQueryRunnerQuery test_query_aggregates_multiple_repository_totals

Stack Traces | 0.072s run time

self = <tests.test_charts.TestChartQueryRunnerQuery testMethod=test_query_aggregates_multiple_repository_totals>

    @override_settings(GITHUB_CLIENT_ID="3d44be0e772666136a13")
    def test_query_aggregates_multiple_repository_totals(self):
        query_runner = ChartQueryRunner(
            user=self.user,
            request_params={
                "owner_username": self.org.username,
                "service": self.org.service,
                "end_date": str(timezone.now()),
                "grouping_unit": "day",
            },
        )
    
        results = query_runner.run_query()
    
        assert len(results) == 1
>       assert results[0]["total_hits"] == 114
E       AssertionError: assert Decimal('14') == 114

.../internal/tests/test_charts.py:564: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

[JerrySentry]

How come TA can't use git_service?

[nora-codecov]

Since it's already live in prod I figured it would be a whole thing to switch over to a different var name - what do you think @joseph-sentry ?

[github-actions]

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

[nora-codecov]

@joseph-sentry can you double check the changes I made to the TA fields? Is this still the design we're going with?

[JerrySentry]

looks good on bundle analysis side of things.