Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send email to admins on failed payment #947

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

This PR adds code to send emails (through the send email worker task) to all owner admins when an invoice payment fails. We are doing this because the current stripe behavior only sends the notification email to the address associated with the stripe customer.

Depends on codecov/worker#835

Closes codecov/engineering-team#2483
Closes codecov/engineering-team#2484
Closes codecov/engineering-team#2485

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review October 30, 2024 16:30
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (f0fcbcc) to head (f81dfdc).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #947   +/-   ##
=======================================
  Coverage   96.24%   96.25%           
=======================================
  Files         826      826           
  Lines       19020    19035   +15     
=======================================
+ Hits        18306    18322   +16     
+ Misses        714      713    -1     
Flag Coverage Δ
unit 92.50% <100.00%> (+0.01%) ⬆️
unit-latest-uploader 92.50% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/send-failed-payment-email branch from 09da596 to 3e28326 Compare November 1, 2024 17:03
billing/views.py Outdated Show resolved Hide resolved
billing/views.py Outdated Show resolved Hide resolved
@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/send-failed-payment-email branch from aebf04f to f81dfdc Compare November 4, 2024 17:09
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 97f26ab Nov 4, 2024
18 of 19 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/send-failed-payment-email branch November 4, 2024 18:22
spalmurray-codecov added a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants