add true tokenless to all upload endpoints, remove from TR #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nora-codecov
commented
Nov 4, 2024
| @@ -59,7 +58,6 @@ class TestResultsView( | |||
| ): | |||
| permission_classes = [UploadTestResultsPermission] | |||
| authentication_classes = [ | |||
| UploadTokenRequiredAuthenticationCheck, | |||
There was a problem hiding this comment.
TR needs a custom method, this is in an upcoming pr. We can leave this auth method in the stack, but it would never evaluate to True.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 826 826
Lines 19040 19040
=======================================
Hits 18326 18326
Misses 714 714
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swatinem
approved these changes
Nov 5, 2024
adrian-codecov
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to relevant tickets
codecov/engineering-team#2300
What does this PR do?
Auth stack on upload endpoints needs to match what's on
shelter, which treats all upload endpoints equally.