Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update GCS bucket name for staging #969

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

ajay-sentry
Copy link
Contributor

Purpose/Motivation

Closes Sentry error https://codecov.sentry.io/issues/6058399091/?environment=staging&project=5215654&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=date&statsPeriod=14d&stream_index=5 related to access denied issue on staging when trying to fetch test results

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

sentry-io bot commented Nov 11, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: utils/test_results.py

Function Unhandled Issue
get_results GraphQLError: module 'shared.celery_config' has no attribute 'cache_test_rollups_redis_task_name' ...
Event Count: 29

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.03%. Comparing base (b71179e) to head (8e26db7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
codecov/settings_staging.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
- Coverage   96.04%   96.03%   -0.01%     
==========================================
  Files         827      827              
  Lines       19068    19071       +3     
==========================================
+ Hits        18313    18315       +2     
- Misses        755      756       +1     
Flag Coverage Δ
unit 92.27% <75.00%> (-0.01%) ⬇️
unit-latest-uploader 92.27% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
codecov/settings_staging.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@ajay-sentry ajay-sentry added this pull request to the merge queue Nov 12, 2024
@@ -115,6 +115,10 @@

DATABASE_ROUTERS = ["codecov.db.DatabaseRouter"]

# GCS
GCS_BUCKET_NAME = "codecov"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think technically we have a bunch of different buckets (like a separate one for bundle analysis)?
Not sure the organizational scheme we've got going on there to offer an alternative name here, so approved it

Merged via the queue into main with commit 70b4692 Nov 12, 2024
17 of 19 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/update-bucket-name-stage branch November 12, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants