Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dynamically import prism langs #2398

Closed
nicholas-codecov opened this issue Aug 26, 2024 · 1 comment · Fixed by codecov/gazebo#3149 or codecov/gazebo#3165
Closed

feat: Dynamically import prism langs #2398

nicholas-codecov opened this issue Aug 26, 2024 · 1 comment · Fixed by codecov/gazebo#3149 or codecov/gazebo#3165
Assignees

Comments

@nicholas-codecov
Copy link

          just some food for thought: is it possible to load these on-demand after matching the file extension?

its also weird that you are using require here instead of bare import statements. is there a particular reason for that?

Originally posted by @Swatinem in codecov/gazebo#3138 (comment)

@nicholas-codecov nicholas-codecov self-assigned this Aug 26, 2024
@nicholas-codecov
Copy link
Author

Dove a bit deeper into this, and it's possible but not really in a clean way. As well another thing to consider after chatting w/@JonasBa, this is a fairly core dependency to Gazebo, so we're alright with the tradeoff of everything being loading all the time.

Other things have been done to remove overall bundle size, such as optimizing our SVGs which offset overall the overall bundle size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant