feat, ref: Round 2 - More language support and some tweaks to Prism setup #3165

nicholas-codecov · 2024-09-05T19:31:49Z

Description

Some additional language support, and locating all prism stuff within a single directory. Second round, turns out we do need the types package.

Closes codecov/engineering-team#2398

… all the lang imports

…espace declartions for us

codecov-staging · 2024-09-06T09:52:57Z

Bundle Report

Changes will increase total bundle size by 7.42kB ⬆️

Bundle name	Size	Change
gazebo-staging-array-push	5.99MB	7.42kB ⬆️

codecov · 2024-09-06T09:52:59Z

Bundle Report

Changes will increase total bundle size by 7.42kB ⬆️

Bundle name	Size	Change
gazebo-production-array-push	5.99MB	7.42kB ⬆️

codecov-public-qa · 2024-09-06T09:53:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (74d2e9e) to head (8f52936).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3165      +/-   ##
==========================================
- Coverage   98.25%   98.24%   -0.01%     
==========================================
  Files         932      933       +1     
  Lines       14458    14458              
  Branches     3917     3917              
==========================================
- Hits        14205    14204       -1     
- Misses        248      249       +1     
  Partials        5        5

Files	Coverage Δ
...DetailPage/CommitCoverage/YamlModal/YAMLViewer.jsx	`100.00% <ø> (ø)`
src/shared/utils/prism/prismLanguageMapper.ts	`100.00% <ø> (ø)`
src/shared/utils/prism/prismLanguages.ts	`100.00% <100.00%> (ø)`
src/shared/utils/prism/prismTheme.css	`100.00% <ø> (ø)`
src/ui/CodeRenderer/CodeRenderer.tsx	`100.00% <ø> (ø)`
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx	`99.12% <ø> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.48% <ø> (ø)`
Layouts	`98.87% <ø> (ø)`
Pages	`99.03% <ø> (ø)`
Services	`99.44% <ø> (-0.04%)`	⬇️
Shared	`99.51% <100.00%> (ø)`
UI	`94.60% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d2e9e...8f52936. Read the comment docs.

codecov · 2024-09-06T09:53:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (74d2e9e) to head (8f52936).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@               Coverage Diff                @@
##               main      #3165        +/-   ##
================================================
- Coverage   98.25000   98.24000   -0.01000     
================================================
  Files           932        933         +1     
  Lines         14458      14458                
  Branches       3944       3862        -82     
================================================
- Hits          14205      14204         -1     
- Misses          248        249         +1     
  Partials          5          5

Files with missing lines	Coverage Δ
...DetailPage/CommitCoverage/YamlModal/YAMLViewer.jsx	`100.00% <ø> (ø)`
src/shared/utils/prism/prismLanguageMapper.ts	`100.00% <ø> (ø)`
src/shared/utils/prism/prismLanguages.ts	`100.00% <100.00%> (ø)`
src/shared/utils/prism/prismTheme.css	`100.00% <ø> (ø)`
src/ui/CodeRenderer/CodeRenderer.tsx	`100.00% <ø> (ø)`
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx	`99.12% <ø> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.48% <ø> (ø)`
Layouts	`98.87% <ø> (ø)`
Pages	`99.03% <ø> (ø)`
Services	`99.44% <ø> (-0.04%)`	⬇️
Shared	`99.51% <100.00%> (ø)`
UI	`94.60% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d2e9e...8f52936. Read the comment docs.

codecov-notifications · 2024-09-06T09:54:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3165      +/-   ##
==========================================
- Coverage   98.25%   98.24%   -0.01%     
==========================================
  Files         932      933       +1     
  Lines       14458    14458              
  Branches     3949     3949              
==========================================
- Hits        14205    14204       -1     
- Misses        248      249       +1     
  Partials        5        5

Files	Coverage Δ
...DetailPage/CommitCoverage/YamlModal/YAMLViewer.jsx	`100.00% <ø> (ø)`
src/shared/utils/prism/prismLanguageMapper.ts	`100.00% <ø> (ø)`
src/shared/utils/prism/prismLanguages.ts	`100.00% <100.00%> (ø)`
src/shared/utils/prism/prismTheme.css	`100.00% <ø> (ø)`
src/ui/CodeRenderer/CodeRenderer.tsx	`100.00% <ø> (ø)`
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx	`99.12% <ø> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.48% <ø> (ø)`
Layouts	`98.87% <ø> (ø)`
Pages	`99.03% <ø> (ø)`
Services	`99.44% <ø> (-0.04%)`	⬇️
Shared	`99.51% <100.00%> (ø)`
UI	`94.60% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d2e9e...8f52936. Read the comment docs.

codecov-qa · 2024-09-06T09:56:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (74d2e9e) to head (8f52936).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3165      +/-   ##
==========================================
- Coverage   98.25%   98.24%   -0.01%     
==========================================
  Files         932      933       +1     
  Lines       14458    14458              
  Branches     3917     3862      -55     
==========================================
- Hits        14205    14204       -1     
- Misses        248      249       +1     
  Partials        5        5

Files with missing lines	Coverage Δ
...DetailPage/CommitCoverage/YamlModal/YAMLViewer.jsx	`100.00% <ø> (ø)`
src/shared/utils/prism/prismLanguageMapper.ts	`100.00% <ø> (ø)`
src/shared/utils/prism/prismLanguages.ts	`100.00% <100.00%> (ø)`
src/shared/utils/prism/prismTheme.css	`100.00% <ø> (ø)`
src/ui/CodeRenderer/CodeRenderer.tsx	`100.00% <ø> (ø)`
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx	`99.12% <ø> (ø)`

... and 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`53.48% <ø> (ø)`
Layouts	`98.87% <ø> (ø)`
Pages	`99.03% <ø> (ø)`
Services	`99.44% <ø> (-0.04%)`	⬇️
Shared	`99.51% <100.00%> (ø)`
UI	`94.60% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d2e9e...8f52936. Read the comment docs.

codecov-releaser · 2024-09-06T09:57:23Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`8f52936`	Fri, 06 Sep 2024 09:57:23 GMT	Cloud	Enterprise

nicholas-codecov added 9 commits September 5, 2024 09:34

add in prismjs types

6f2e8d5

move prism related stuff into it's own dir, and create a file to hold…

2ec413b

… all the lang imports

update imports of prism stuff

72c4880

fix some type issues

3125024

swap import style

496b1d7

actually import lua

93bd14c

remove prism js types as they don't work for our use case

03a91a4

turns out we do need the types package, as it provides the global nam…

42442a4

…espace declartions for us

it should be a dev dep

07c98e4

nicholas-codecov changed the title ~~feat, ref: More language support and some tweaks to Prism setup round 2~~ feat, ref: Round 2 - More language support and some tweaks to Prism setup Sep 5, 2024

ajay-sentry approved these changes Sep 5, 2024

View reviewed changes

Merge branch 'main' into gh-eng-2398-feat-dynamically-import-prism-langs

8f52936

nicholas-codecov added this pull request to the merge queue Sep 6, 2024

Merged via the queue into main with commit e6a4224 Sep 6, 2024
62 checks passed

nicholas-codecov deleted the gh-eng-2398-feat-dynamically-import-prism-langs branch September 6, 2024 09:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat, ref: Round 2 - More language support and some tweaks to Prism setup #3165

feat, ref: Round 2 - More language support and some tweaks to Prism setup #3165

nicholas-codecov commented Sep 5, 2024

codecov-staging bot commented Sep 6, 2024

codecov bot commented Sep 6, 2024

codecov-public-qa bot commented Sep 6, 2024

codecov bot commented Sep 6, 2024 •

edited

Loading

codecov-notifications bot commented Sep 6, 2024 •

edited

Loading

codecov-qa bot commented Sep 6, 2024 •

edited

Loading

codecov-releaser commented Sep 6, 2024

feat, ref: Round 2 - More language support and some tweaks to Prism setup #3165

feat, ref: Round 2 - More language support and some tweaks to Prism setup #3165

Conversation

nicholas-codecov commented Sep 5, 2024

Description

codecov-staging bot commented Sep 6, 2024

Bundle Report

codecov bot commented Sep 6, 2024

Bundle Report

codecov-public-qa bot commented Sep 6, 2024

Codecov Report

codecov bot commented Sep 6, 2024 • edited Loading

Codecov Report

codecov-notifications bot commented Sep 6, 2024 • edited Loading

Codecov Report

codecov-qa bot commented Sep 6, 2024 • edited Loading

Codecov Report

codecov-releaser commented Sep 6, 2024

✅ Deploy preview for gazebo ready!

codecov bot commented Sep 6, 2024 •

edited

Loading

codecov-notifications bot commented Sep 6, 2024 •

edited

Loading

codecov-qa bot commented Sep 6, 2024 •

edited

Loading