Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create drop downs for Commit Detail page #2541

Merged

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Jan 26, 2024

Description

This PR adds in the drop downs that will be used in the commit detail page.

GH codecov/engineering-team#996

Note

Requires #2535 and #2540

Notable Changes

  • Small style tweaks to the SummaryDropdown component
  • Adds in summary drop down for coverage
  • Adds in summary drop down for bundles

Screenshots

Drop downs not expanded:

Screenshot 2024-01-26 at 08 17 53

Drop downs expanded:

Screenshot 2024-01-26 at 09 12 29

@codecov-staging
Copy link

codecov-staging bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2541   +/-   ##
=======================================
  Coverage   98.31%   98.32%           
=======================================
  Files         803      805    +2     
  Lines       10408    10442   +34     
  Branches     2577     2619   +42     
=======================================
+ Hits        10233    10267   +34     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...ommitDetailPage/Dropdowns/CommitBundleDropdown.tsx 100.00% <100.00%> (ø)
...mitDetailPage/Dropdowns/CommitCoverageDropdown.tsx 100.00% <100.00%> (ø)
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf68080...6185ad9. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 26, 2024

Codecov Report

Merging #2541 (6185ad9) into main (cf68080) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2541   +/-   ##
=======================================
  Coverage   98.31%   98.32%           
=======================================
  Files         803      805    +2     
  Lines       10408    10442   +34     
  Branches     2577     2633   +56     
=======================================
+ Hits        10233    10267   +34     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...ommitDetailPage/Dropdowns/CommitBundleDropdown.tsx 100.00% <100.00%> (ø)
...mitDetailPage/Dropdowns/CommitCoverageDropdown.tsx 100.00% <100.00%> (ø)
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf68080...6185ad9. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf68080) 98.31% compared to head (6185ad9) 98.32%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2541   +/-   ##
=======================================
  Coverage   98.31%   98.32%           
=======================================
  Files         803      805    +2     
  Lines       10408    10442   +34     
  Branches     2577     2633   +56     
=======================================
+ Hits        10233    10267   +34     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...ommitDetailPage/Dropdowns/CommitBundleDropdown.tsx 100.00% <100.00%> (ø)
...mitDetailPage/Dropdowns/CommitCoverageDropdown.tsx 100.00% <100.00%> (ø)
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf68080...6185ad9. Read the comment docs.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 6185ad9
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65b3c8d27d097c000864b45e
😎 Deploy Preview https://deploy-preview-2541--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf68080) 98.32% compared to head (6185ad9) 98.32%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2541   +/-   ##
=====================================
  Coverage   98.32   98.32           
=====================================
  Files        803     805    +2     
  Lines      10408   10442   +34     
  Branches    2623    2587   -36     
=====================================
+ Hits       10233   10267   +34     
  Misses       173     173           
  Partials       2       2           
Files Coverage Δ
...ommitDetailPage/Dropdowns/CommitBundleDropdown.tsx 100.00% <100.00%> (ø)
...mitDetailPage/Dropdowns/CommitCoverageDropdown.tsx 100.00% <100.00%> (ø)
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf68080...6185ad9. Read the comment docs.

@codecov-releaser
Copy link
Contributor

Visit https://preview-pr-2541.codecov.dev for your PR preview. Expires after 1 month automatically.

Copy link
Contributor

@RulaKhaled RulaKhaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@nicholas-codecov nicholas-codecov merged commit 7e1c7df into main Jan 26, 2024
57 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-996-create-dropdowns-for-commit-detail-page branch January 26, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants