Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update with components specific errors #2543

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

RulaKhaled
Copy link
Contributor

Description

Display components specific errors in file explorer tabs

Notable Changes

  • Adjusting missing data in file explorer in coverage tab
  • Adjusting missing data in both commit and PR pages

Screenshots

Screenshot 2024-01-25 at 3 33 35 PM Screenshot 2024-01-25 at 3 33 29 PM

closes: codecov/engineering-team#989

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 484d1cf
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65b3c2df1b4e9e00084492c9
😎 Deploy Preview https://deploy-preview-2543--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-releaser
Copy link
Contributor

Visit https://preview-pr-2543.codecov.dev for your PR preview. Expires after 1 month automatically.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me 👍

Copy link

codecov-public-qa bot commented Jan 26, 2024

Codecov Report

Merging #2543 (484d1cf) into main (00ccb03) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2543   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         803      803           
  Lines       10400    10408    +8     
  Branches     2573     2623   +50     
=======================================
+ Hits        10225    10233    +8     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
.../PullCoverage/routes/FileExplorer/FileExplorer.jsx 100.00% <ø> (ø)
...route/FileExplorer/CodeTreeTable/CodeTreeTable.jsx 100.00% <ø> (ø)
...route/FileExplorer/FileListTable/FileListTable.jsx 100.00% <ø> (ø)
...ubroute/FileExplorer/shared/RepoContentsResult.tsx 100.00% <100.00%> (ø)
.../ContentsTable/MissingFileData/MissingFileData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <100.00%> (+<0.01%) ⬆️
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ccb03...484d1cf. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2543   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         803      803           
  Lines       10400    10408    +8     
  Branches     2624     2609   -15     
=======================================
+ Hits        10225    10233    +8     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
.../PullCoverage/routes/FileExplorer/FileExplorer.jsx 100.00% <ø> (ø)
...route/FileExplorer/CodeTreeTable/CodeTreeTable.jsx 100.00% <ø> (ø)
...route/FileExplorer/FileListTable/FileListTable.jsx 100.00% <ø> (ø)
...ubroute/FileExplorer/shared/RepoContentsResult.tsx 100.00% <100.00%> (ø)
.../ContentsTable/MissingFileData/MissingFileData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <100.00%> (+<0.01%) ⬆️
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ccb03...484d1cf. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00ccb03) 98.31% compared to head (484d1cf) 98.31%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2543   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         803      803           
  Lines       10400    10408    +8     
  Branches     2619     2579   -40     
=======================================
+ Hits        10225    10233    +8     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
.../PullCoverage/routes/FileExplorer/FileExplorer.jsx 100.00% <ø> (ø)
...route/FileExplorer/CodeTreeTable/CodeTreeTable.jsx 100.00% <ø> (ø)
...route/FileExplorer/FileListTable/FileListTable.jsx 100.00% <ø> (ø)
...ubroute/FileExplorer/shared/RepoContentsResult.tsx 100.00% <100.00%> (ø)
.../ContentsTable/MissingFileData/MissingFileData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <100.00%> (+<0.01%) ⬆️
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ccb03...484d1cf. Read the comment docs.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00ccb03) 98.32% compared to head (484d1cf) 98.32%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2543   +/-   ##
=====================================
  Coverage   98.32   98.32           
=====================================
  Files        803     803           
  Lines      10400   10408    +8     
  Branches    2573    2628   +55     
=====================================
+ Hits       10225   10233    +8     
  Misses       173     173           
  Partials       2       2           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
.../PullCoverage/routes/FileExplorer/FileExplorer.jsx 100.00% <ø> (ø)
...route/FileExplorer/CodeTreeTable/CodeTreeTable.jsx 100.00% <ø> (ø)
...route/FileExplorer/FileListTable/FileListTable.jsx 100.00% <ø> (ø)
...ubroute/FileExplorer/shared/RepoContentsResult.tsx 100.00% <100.00%> (ø)
.../ContentsTable/MissingFileData/MissingFileData.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.55% <ø> (ø)
Shared 99.82% <100.00%> (+<0.01%) ⬆️
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ccb03...484d1cf. Read the comment docs.

@RulaKhaled RulaKhaled merged commit cf68080 into main Jan 26, 2024
60 checks passed
@RulaKhaled RulaKhaled deleted the flags-components-polish-0 branch January 26, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flags+Component Selector interaction error messaging polish
3 participants