Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Optimize SVGs #3142

Merged
merged 2 commits into from
Aug 26, 2024
Merged

ref: Optimize SVGs #3142

merged 2 commits into from
Aug 26, 2024

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Aug 21, 2024

Description

This PR optimizes some of our svgs by reducing their precision.

@codecov-staging
Copy link

codecov-staging bot commented Aug 21, 2024

Bundle Report

Changes will decrease total bundle size by 111.89kB ⬇️

Bundle name Size Change
gazebo-staging-array-push 5.67MB 111.89kB ⬇️

Copy link

codecov bot commented Aug 21, 2024

Bundle Report

Changes will decrease total bundle size by 111.89kB ⬇️

Bundle name Size Change
gazebo-production-array-push 5.67MB 111.89kB ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 57.77778% with 19 lines in your changes missing coverage. Please review.

Project coverage is 98.30%. Comparing base (845a181) to head (d0b3eac).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files Patch % Lines
src/assets/billing/amex.svg 50.00% 2 Missing ⚠️
src/assets/billing/discover.svg 50.00% 2 Missing ⚠️
src/assets/billing/mastercard.svg 50.00% 2 Missing ⚠️
src/assets/providers/bitbucket-icon.svg 33.33% 2 Missing ⚠️
src/assets/providers/github-icon.svg 50.00% 2 Missing ⚠️
src/assets/providers/gitlab-icon.svg 50.00% 2 Missing ⚠️
src/assets/svg/graphs/icicle.svg 50.00% 2 Missing ⚠️
src/assets/svg/graphs/sunburst.svg 50.00% 2 Missing ⚠️
src/assets/svg/graphs/tree.svg 50.00% 2 Missing ⚠️
src/assets/billing/visa.svg 66.66% 1 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3142   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         919      919           
  Lines       14191    14191           
  Branches     3924     3843   -81     
=======================================
  Hits        13950    13950           
  Misses        236      236           
  Partials        5        5           
Files Coverage Δ
src/assets/flagManagement.svg 50.00% <100.00%> (ø)
src/assets/providers/okta-icon.svg 50.00% <100.00%> (ø)
src/assets/providers/sentry-icon.svg 50.00% <100.00%> (ø)
src/assets/svg/invoice.svg 50.00% <100.00%> (ø)
src/assets/billing/visa.svg 50.00% <66.66%> (ø)
src/assets/billing/amex.svg 50.00% <50.00%> (ø)
src/assets/billing/discover.svg 50.00% <50.00%> (ø)
src/assets/billing/mastercard.svg 50.00% <50.00%> (ø)
src/assets/providers/bitbucket-icon.svg 50.00% <33.33%> (ø)
src/assets/providers/github-icon.svg 50.00% <50.00%> (ø)
... and 4 more
Components Coverage Δ
Assets 54.05% <57.77%> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845a181...d0b3eac. Read the comment docs.

Copy link

codecov-public-qa bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 57.77778% with 19 lines in your changes missing coverage. Please review.

Project coverage is 98.30%. Comparing base (845a181) to head (d0b3eac).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3142   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         919      919           
  Lines       14191    14191           
  Branches     3898     3843   -55     
=======================================
  Hits        13950    13950           
  Misses        236      236           
  Partials        5        5           
Files Coverage Δ
src/assets/flagManagement.svg 50.00% <100.00%> (ø)
src/assets/providers/okta-icon.svg 50.00% <100.00%> (ø)
src/assets/providers/sentry-icon.svg 50.00% <100.00%> (ø)
src/assets/svg/invoice.svg 50.00% <100.00%> (ø)
src/assets/billing/visa.svg 50.00% <66.66%> (ø)
src/assets/billing/amex.svg 50.00% <50.00%> (ø)
src/assets/billing/discover.svg 50.00% <50.00%> (ø)
src/assets/billing/mastercard.svg 50.00% <50.00%> (ø)
src/assets/providers/bitbucket-icon.svg 50.00% <33.33%> (ø)
src/assets/providers/github-icon.svg 50.00% <50.00%> (ø)
... and 4 more
Components Coverage Δ
Assets 54.05% <57.77%> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845a181...d0b3eac. Read the comment docs.

@nicholas-codecov nicholas-codecov marked this pull request as ready for review August 21, 2024 17:56
@codecov-notifications
Copy link

codecov-notifications bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 57.77778% with 19 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
src/assets/billing/amex.svg 50.00% 2 Missing ⚠️
src/assets/billing/discover.svg 50.00% 2 Missing ⚠️
src/assets/billing/mastercard.svg 50.00% 2 Missing ⚠️
src/assets/providers/bitbucket-icon.svg 33.33% 2 Missing ⚠️
src/assets/providers/github-icon.svg 50.00% 2 Missing ⚠️
src/assets/providers/gitlab-icon.svg 50.00% 2 Missing ⚠️
src/assets/svg/graphs/icicle.svg 50.00% 2 Missing ⚠️
src/assets/svg/graphs/sunburst.svg 50.00% 2 Missing ⚠️
src/assets/svg/graphs/tree.svg 50.00% 2 Missing ⚠️
src/assets/billing/visa.svg 66.66% 1 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3142   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         919      919           
  Lines       14191    14191           
  Branches     3843     3843           
=======================================
  Hits        13950    13950           
  Misses        236      236           
  Partials        5        5           
Files Coverage Δ
src/assets/flagManagement.svg 50.00% <100.00%> (ø)
src/assets/providers/okta-icon.svg 50.00% <100.00%> (ø)
src/assets/providers/sentry-icon.svg 50.00% <100.00%> (ø)
src/assets/svg/invoice.svg 50.00% <100.00%> (ø)
src/assets/billing/visa.svg 50.00% <66.66%> (ø)
src/assets/billing/amex.svg 50.00% <50.00%> (ø)
src/assets/billing/discover.svg 50.00% <50.00%> (ø)
src/assets/billing/mastercard.svg 50.00% <50.00%> (ø)
src/assets/providers/bitbucket-icon.svg 50.00% <33.33%> (ø)
src/assets/providers/github-icon.svg 50.00% <50.00%> (ø)
... and 4 more
Components Coverage Δ
Assets 54.05% <57.77%> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845a181...d0b3eac. Read the comment docs.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 57.77778% with 19 lines in your changes missing coverage. Please review.

Project coverage is 98.30%. Comparing base (845a181) to head (d0b3eac).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files Patch % Lines
src/assets/billing/amex.svg 50.00% 2 Missing ⚠️
src/assets/billing/discover.svg 50.00% 2 Missing ⚠️
src/assets/billing/mastercard.svg 50.00% 2 Missing ⚠️
src/assets/providers/bitbucket-icon.svg 33.33% 2 Missing ⚠️
src/assets/providers/github-icon.svg 50.00% 2 Missing ⚠️
src/assets/providers/gitlab-icon.svg 50.00% 2 Missing ⚠️
src/assets/svg/graphs/icicle.svg 50.00% 2 Missing ⚠️
src/assets/svg/graphs/sunburst.svg 50.00% 2 Missing ⚠️
src/assets/svg/graphs/tree.svg 50.00% 2 Missing ⚠️
src/assets/billing/visa.svg 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3142   +/-   ##
===========================================
  Coverage   98.30000   98.30000           
===========================================
  Files           919        919           
  Lines         14191      14191           
  Branches       3843       3924   +81     
===========================================
  Hits          13950      13950           
  Misses          236        236           
  Partials          5          5           
Files Coverage Δ
src/assets/flagManagement.svg 50.00% <100.00%> (ø)
src/assets/providers/okta-icon.svg 50.00% <100.00%> (ø)
src/assets/providers/sentry-icon.svg 50.00% <100.00%> (ø)
src/assets/svg/invoice.svg 50.00% <100.00%> (ø)
src/assets/billing/visa.svg 50.00% <66.66%> (ø)
src/assets/billing/amex.svg 50.00% <50.00%> (ø)
src/assets/billing/discover.svg 50.00% <50.00%> (ø)
src/assets/billing/mastercard.svg 50.00% <50.00%> (ø)
src/assets/providers/bitbucket-icon.svg 50.00% <33.33%> (ø)
src/assets/providers/github-icon.svg 50.00% <50.00%> (ø)
... and 4 more
Components Coverage Δ
Assets 54.05% <57.77%> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845a181...d0b3eac. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Aug 21, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
20b46f2 Wed, 21 Aug 2024 17:59:01 GMT Expired Expired
d0b3eac Wed, 21 Aug 2024 23:38:48 GMT Cloud Enterprise

Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/assets/svg/flagManagement.svg and src/assets/flagManagement.svg have the same filename, and they look very similar, the second one seems to be a crop of the first one.
May it be worth as a followup to unify those, and apply the crop client-side somehow?

@nicholas-codecov
Copy link
Contributor Author

src/assets/svg/flagManagement.svg and src/assets/flagManagement.svg have the same filename, and they look very similar, the second one seems to be a crop of the first one. May it be worth as a followup to unify those, and apply the crop client-side somehow?

Hrrm, yea I think we could probably do something like that

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 93030af Aug 26, 2024
57 of 61 checks passed
@nicholas-codecov nicholas-codecov deleted the ref-svg-optimizations branch August 26, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants