-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Optimize SVGs #3142
ref: Optimize SVGs #3142
Conversation
Bundle ReportChanges will decrease total bundle size by 111.89kB ⬇️
|
Bundle ReportChanges will decrease total bundle size by 111.89kB ⬇️
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3142 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 919 919
Lines 14191 14191
Branches 3924 3843 -81
=======================================
Hits 13950 13950
Misses 236 236
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3142 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 919 919
Lines 14191 14191
Branches 3898 3843 -55
=======================================
Hits 13950 13950
Misses 236 236
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3142 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 919 919
Lines 14191 14191
Branches 3843 3843
=======================================
Hits 13950 13950
Misses 236 236
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3142 +/- ##
===========================================
Coverage 98.30000 98.30000
===========================================
Files 919 919
Lines 14191 14191
Branches 3843 3924 +81
===========================================
Hits 13950 13950
Misses 236 236
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/assets/svg/flagManagement.svg
and src/assets/flagManagement.svg
have the same filename, and they look very similar, the second one seems to be a crop of the first one.
May it be worth as a followup to unify those, and apply the crop client-side somehow?
Hrrm, yea I think we could probably do something like that |
Description
This PR optimizes some of our svgs by reducing their precision.