Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clean up okta feature flag #3144

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: Clean up okta feature flag #3144

merged 1 commit into from
Aug 26, 2024

Conversation

RulaKhaled
Copy link
Contributor

Description

Removing feature flag as it's fully released now.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Bundle Report

Changes will decrease total bundle size by 158 bytes ⬇️

Bundle name Size Change
gazebo-staging-array-push 5.78MB 158 bytes ⬇️

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (3ed348a) to head (4075b2d).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3144      +/-   ##
==========================================
- Coverage   98.30%   98.30%   -0.01%     
==========================================
  Files         919      919              
  Lines       14191    14184       -7     
  Branches     3898     3923      +25     
==========================================
- Hits        13950    13943       -7     
  Misses        236      236              
  Partials        5        5              
Files Coverage Δ
src/pages/AccountSettings/AccountSettings.jsx 100.00% <100.00%> (ø)
.../pages/AccountSettings/AccountSettingsSideMenu.jsx 100.00% <100.00%> (ø)
...hared/GlobalTopBanners/OktaBanners/OktaBanners.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <100.00%> (-0.01%) ⬇️
Services 99.51% <ø> (ø)
Shared 99.71% <100.00%> (-0.01%) ⬇️
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed348a...4075b2d. Read the comment docs.

Copy link

codecov bot commented Aug 23, 2024

Bundle Report

Changes will decrease total bundle size by 158 bytes ⬇️

Bundle name Size Change
gazebo-production-array-push 5.78MB 158 bytes ⬇️

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (3ed348a) to head (4075b2d).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3144   +/-   ##
===========================================
  Coverage   98.30000   98.30000           
===========================================
  Files           919        919           
  Lines         14191      14184    -7     
  Branches       3924       3918    -6     
===========================================
- Hits          13950      13943    -7     
  Misses          236        236           
  Partials          5          5           
Files Coverage Δ
src/pages/AccountSettings/AccountSettings.jsx 100.00% <100.00%> (ø)
.../pages/AccountSettings/AccountSettingsSideMenu.jsx 100.00% <100.00%> (ø)
...hared/GlobalTopBanners/OktaBanners/OktaBanners.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <100.00%> (-0.01%) ⬇️
Services 99.51% <ø> (ø)
Shared 99.71% <100.00%> (-0.01%) ⬇️
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed348a...4075b2d. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
4075b2d Fri, 23 Aug 2024 09:14:31 GMT Cloud Enterprise

@codecov-qa
Copy link

codecov-qa bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (3ed348a) to head (4075b2d).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3144      +/-   ##
==========================================
- Coverage   98.30%   98.30%   -0.01%     
==========================================
  Files         919      919              
  Lines       14191    14184       -7     
  Branches     3929     3837      -92     
==========================================
- Hits        13950    13943       -7     
  Misses        236      236              
  Partials        5        5              
Files Coverage Δ
src/pages/AccountSettings/AccountSettings.jsx 100.00% <100.00%> (ø)
.../pages/AccountSettings/AccountSettingsSideMenu.jsx 100.00% <100.00%> (ø)
...hared/GlobalTopBanners/OktaBanners/OktaBanners.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <100.00%> (-0.01%) ⬇️
Services 99.51% <ø> (ø)
Shared 99.71% <100.00%> (-0.01%) ⬇️
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed348a...4075b2d. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3144      +/-   ##
==========================================
- Coverage   98.30%   98.30%   -0.01%     
==========================================
  Files         919      919              
  Lines       14191    14184       -7     
  Branches     3898     3918      +20     
==========================================
- Hits        13950    13943       -7     
  Misses        236      236              
  Partials        5        5              
Files Coverage Δ
src/pages/AccountSettings/AccountSettings.jsx 100.00% <100.00%> (ø)
.../pages/AccountSettings/AccountSettingsSideMenu.jsx 100.00% <100.00%> (ø)
...hared/GlobalTopBanners/OktaBanners/OktaBanners.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <100.00%> (-0.01%) ⬇️
Services 99.51% <ø> (ø)
Shared 99.71% <100.00%> (-0.01%) ⬇️
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed348a...4075b2d. Read the comment docs.

@RulaKhaled RulaKhaled added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 79bdab2 Aug 26, 2024
61 checks passed
@RulaKhaled RulaKhaled deleted the clean-up-flags branch August 26, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants