fix: Show enable button in components/flags for activated users only #3145
Conversation
Bundle ReportChanges will decrease total bundle size by 65.14kB ⬇️
|
Bundle ReportChanges will decrease total bundle size by 65.14kB ⬇️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3145 +/- ##
==========================================
- Coverage 98.31% 98.31% -0.01%
==========================================
Files 919 923 +4
Lines 14177 14400 +223
Branches 3921 3910 -11
==========================================
+ Hits 13938 14157 +219
- Misses 234 238 +4
Partials 5 5
... and 20 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3145 +/- ##
==========================================
- Coverage 98.31% 98.31% -0.01%
==========================================
Files 919 923 +4
Lines 14177 14400 +223
Branches 3840 3936 +96
==========================================
+ Hits 13938 14157 +219
- Misses 234 238 +4
Partials 5 5
... and 20 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3145 +/- ##
============================================
Coverage 98.31000 98.31000
============================================
Files 919 923 +4
Lines 14177 14400 +223
Branches 3926 3855 -71
============================================
+ Hits 13938 14157 +219
- Misses 234 238 +4
Partials 5 5
... and 20 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3145 +/- ##
==========================================
- Coverage 98.31% 98.31% -0.01%
==========================================
Files 919 923 +4
Lines 14177 14400 +223
Branches 3921 3936 +15
==========================================
+ Hits 13938 14157 +219
- Misses 234 238 +4
Partials 5 5
... and 20 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
| @@ -64,9 +63,6 @@ query GetRepoSettingsTeam($name: String!, $repo: String!) { | |||
| ... on NotFoundError { | |||
| message | |||
| } | |||
| ... on OwnerNotActivatedError { | |||
There was a problem hiding this comment.
this is handled in the /repo page level
Description
We show
enable anaylticsbutton for non logged in users, this fixes so that if current user is not part of org, we don't show the enabled button.issue: codecov/feedback#452
Notable Changes
Screenshots
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.