Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add gaps back in #3166

Merged
merged 4 commits into from
Sep 6, 2024
Merged

fix: Add gaps back in #3166

merged 4 commits into from
Sep 6, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

Some gaps were removed, removing the padding from the PR and Commit pages, this PR adds them back in.

Screenshots

Before:

Screenshot 2024-09-06 at 09 13 32

After:

Screenshot 2024-09-06 at 09 13 39

@nicholas-codecov nicholas-codecov changed the title fix: Add gap back in fix: Add gaps back in Sep 6, 2024
@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 12 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.99MB 12 bytes ⬆️

@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 107 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 5.99MB 107 bytes ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (e6a4224) to head (4be7ea1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3166      +/-   ##
==========================================
- Coverage   98.25%   98.24%   -0.01%     
==========================================
  Files         933      933              
  Lines       14458    14458              
  Branches     3944     3917      -27     
==========================================
- Hits        14205    14204       -1     
- Misses        248      249       +1     
  Partials        5        5
Files with missing lines Coverage Δ
src/pages/CommitDetailPage/CommitDetailPage.tsx 100.00% <100.00%> (ø)
...tDetailPage/Header/HeaderDefault/HeaderDefault.jsx 100.00% <ø> (ø)
src/pages/PullRequestPage/PullRequestPage.tsx 97.36% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <100.00%> (ø)
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.51% <ø> (ø)
UI 94.60% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a4224...4be7ea1. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (e6a4224) to head (4be7ea1).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3166      +/-   ##
==========================================
- Coverage   98.25%   98.24%   -0.01%     
==========================================
  Files         933      933              
  Lines       14458    14458              
  Branches     3949     3917      -32     
==========================================
- Hits        14205    14204       -1     
- Misses        248      249       +1     
  Partials        5        5
Files Coverage Δ
src/pages/CommitDetailPage/CommitDetailPage.tsx 100.00% <100.00%> (ø)
...tDetailPage/Header/HeaderDefault/HeaderDefault.jsx 100.00% <ø> (ø)
src/pages/PullRequestPage/PullRequestPage.tsx 97.36% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <100.00%> (ø)
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.51% <ø> (ø)
UI 94.60% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a4224...4be7ea1. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3166      +/-   ##
==========================================
- Coverage   98.25%   98.24%   -0.01%     
==========================================
  Files         933      933              
  Lines       14458    14458              
  Branches     3944     3944              
==========================================
- Hits        14205    14204       -1     
- Misses        248      249       +1     
  Partials        5        5
Files Coverage Δ
src/pages/CommitDetailPage/CommitDetailPage.tsx 100.00% <100.00%> (ø)
...tDetailPage/Header/HeaderDefault/HeaderDefault.jsx 100.00% <ø> (ø)
src/pages/PullRequestPage/PullRequestPage.tsx 97.36% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <100.00%> (ø)
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.51% <ø> (ø)
UI 94.60% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a4224...4be7ea1. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Sep 6, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
0f6e9c0 Fri, 06 Sep 2024 12:21:29 GMT Expired Expired
4be7ea1 Fri, 06 Sep 2024 13:48:43 GMT Cloud Enterprise

@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (e6a4224) to head (4be7ea1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3166        +/-   ##
================================================
- Coverage   98.25000   98.24000   -0.01000     
================================================
  Files           933        933                
  Lines         14458      14458                
  Branches       3944       3862        -82     
================================================
- Hits          14205      14204         -1     
- Misses          248        249         +1     
  Partials          5          5
Files with missing lines Coverage Δ
src/pages/CommitDetailPage/CommitDetailPage.tsx 100.00% <100.00%> (ø)
...tDetailPage/Header/HeaderDefault/HeaderDefault.jsx 100.00% <ø> (ø)
src/pages/PullRequestPage/PullRequestPage.tsx 97.36% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <100.00%> (ø)
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.51% <ø> (ø)
UI 94.60% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a4224...4be7ea1. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit 584f6eb Sep 6, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-add-gap-back-in branch September 6, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitvinnakota-codecov rohitvinnakota-codecov rohitvinnakota-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @rohitvinnakota-codecov