Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add nullable to scheduled phase #3167

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

ajay-sentry
Copy link
Contributor

Description

This PR aims to fix an issue where a user was receiving a 404 error due to zod schema failing to parse scheduledPhase being a null value.

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 11 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.99MB 11 bytes ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (584f6eb) to head (32ba54f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3167      +/-   ##
==========================================
- Coverage   98.25%   98.24%   -0.01%     
==========================================
  Files         934      934              
  Lines       14476    14476              
  Branches     3868     3950      +82     
==========================================
- Hits        14223    14222       -1     
- Misses        248      249       +1     
  Partials        5        5              
Files with missing lines Coverage Δ
src/services/account/useAccountDetails.ts 95.45% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.51% <ø> (ø)
UI 94.60% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584f6eb...32ba54f. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3167      +/-   ##
==========================================
- Coverage   98.25%   98.24%   -0.01%     
==========================================
  Files         934      934              
  Lines       14476    14476              
  Branches     3868     3868              
==========================================
- Hits        14223    14222       -1     
- Misses        248      249       +1     
  Partials        5        5              
Files Coverage Δ
src/services/account/useAccountDetails.ts 95.45% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.51% <ø> (ø)
UI 94.60% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584f6eb...32ba54f. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (584f6eb) to head (32ba54f).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3167      +/-   ##
==========================================
- Coverage   98.25%   98.24%   -0.01%     
==========================================
  Files         934      934              
  Lines       14476    14476              
  Branches     3955     3955              
==========================================
- Hits        14223    14222       -1     
- Misses        248      249       +1     
  Partials        5        5              
Files Coverage Δ
src/services/account/useAccountDetails.ts 95.45% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.51% <ø> (ø)
UI 94.60% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584f6eb...32ba54f. Read the comment docs.

@ajay-sentry ajay-sentry added this pull request to the merge queue Sep 6, 2024
@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
32ba54f Fri, 06 Sep 2024 16:42:16 GMT Cloud Enterprise

Copy link

codecov bot commented Sep 6, 2024

Bundle Report

Changes will increase total bundle size by 11 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 5.99MB 11 bytes ⬆️

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (584f6eb) to head (32ba54f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3167        +/-   ##
================================================
- Coverage   98.25000   98.24000   -0.01000     
================================================
  Files           934        934                
  Lines         14476      14476                
  Branches       3868       3868                
================================================
- Hits          14223      14222         -1     
- Misses          248        249         +1     
  Partials          5          5                
Files with missing lines Coverage Δ
src/services/account/useAccountDetails.ts 95.45% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.51% <ø> (ø)
UI 94.60% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584f6eb...32ba54f. Read the comment docs.

Merged via the queue into main with commit 245de72 Sep 6, 2024
61 of 62 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/nullable-sub-detail branch September 6, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants