-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add nullable to scheduled phase #3167
Conversation
Bundle ReportChanges will increase total bundle size by 11 bytes ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3167 +/- ##
==========================================
- Coverage 98.25% 98.24% -0.01%
==========================================
Files 934 934
Lines 14476 14476
Branches 3868 3950 +82
==========================================
- Hits 14223 14222 -1
- Misses 248 249 +1
Partials 5 5
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3167 +/- ##
==========================================
- Coverage 98.25% 98.24% -0.01%
==========================================
Files 934 934
Lines 14476 14476
Branches 3868 3868
==========================================
- Hits 14223 14222 -1
- Misses 248 249 +1
Partials 5 5
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3167 +/- ##
==========================================
- Coverage 98.25% 98.24% -0.01%
==========================================
Files 934 934
Lines 14476 14476
Branches 3955 3955
==========================================
- Hits 14223 14222 -1
- Misses 248 249 +1
Partials 5 5
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Bundle ReportChanges will increase total bundle size by 11 bytes ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3167 +/- ##
================================================
- Coverage 98.25000 98.24000 -0.01000
================================================
Files 934 934
Lines 14476 14476
Branches 3868 3868
================================================
- Hits 14223 14222 -1
- Misses 248 249 +1
Partials 5 5
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Description
This PR aims to fix an issue where a user was receiving a 404 error due to zod schema failing to parse scheduledPhase being a null value.
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.