Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use new coverage analytics graphql schema #3169

Merged
merged 12 commits into from
Sep 27, 2024
Merged

Conversation

suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Sep 9, 2024

Point fields to the new resolvers for the nested types in CoverageAnalytics (changes in api here).

Tested by running against the api changes in staging that the spots this is used (coverage graphs) have no difference in behavior.

Closes codecov/engineering-team#2281

some example side by sides:
Screenshot 2024-09-26 at 8 12 56 PM
Screenshot 2024-09-26 at 8 11 59 PM

@codecov-staging
Copy link

codecov-staging bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3169   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         803      803           
  Lines       14014    14014           
  Branches     3988     3965   -23     
=======================================
  Hits        13843    13843           
  Misses        160      160           
  Partials       11       11           
Files with missing lines Coverage Δ
.../services/charts/useBranchCoverageMeasurements.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (ø)
Pages 98.64% <ø> (ø)
Services 99.41% <100.00%> (ø)
Shared 99.23% <ø> (ø)
UI 98.05% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e61c7...57e450a. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (98e61c7) to head (57e450a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3169   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         803      803           
  Lines       14014    14014           
  Branches     3914     3965   +51     
=======================================
  Hits        13843    13843           
  Misses        160      160           
  Partials       11       11           
Files with missing lines Coverage Δ
.../services/charts/useBranchCoverageMeasurements.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (ø)
Pages 98.64% <ø> (ø)
Services 99.41% <100.00%> (ø)
Shared 99.23% <ø> (ø)
UI 98.05% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e61c7...57e450a. Read the comment docs.

Copy link

codecov-public-qa bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (98e61c7) to head (57e450a).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3169   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         803      803           
  Lines       14014    14014           
  Branches     3914     3988   +74     
=======================================
  Hits        13843    13843           
  Misses        160      160           
  Partials       11       11           
Files Coverage Δ
.../services/charts/useBranchCoverageMeasurements.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (ø)
Pages 98.64% <ø> (ø)
Services 99.41% <100.00%> (ø)
Shared 99.23% <ø> (ø)
UI 98.05% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e61c7...57e450a. Read the comment docs.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (98e61c7) to head (57e450a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3169   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         803      803           
  Lines       14014    14014           
  Branches     3988     3993    +5     
=======================================
  Hits        13843    13843           
  Misses        160      160           
  Partials       11       11           
Files with missing lines Coverage Δ
.../services/charts/useBranchCoverageMeasurements.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (ø)
Pages 98.64% <ø> (ø)
Services 99.41% <100.00%> (ø)
Shared 99.23% <ø> (ø)
UI 98.05% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e61c7...57e450a. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Sep 9, 2024

Bundle Report

Changes will increase total bundle size by 125 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-array-push 6.04MB 125 bytes (0.0%) ⬆️

Copy link

codecov bot commented Sep 9, 2024

Bundle Report

Changes will increase total bundle size by 125 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.04MB 125 bytes (0.0%) ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Sep 9, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
f2dcc57 Mon, 09 Sep 2024 06:36:11 GMT Expired Expired
f7175f4 Thu, 19 Sep 2024 05:09:02 GMT Expired Expired
60066cd Tue, 24 Sep 2024 17:32:25 GMT Expired Expired
1d43cea Wed, 25 Sep 2024 21:47:06 GMT Expired Expired
4fc0c8d Wed, 25 Sep 2024 23:44:18 GMT Expired Expired
139a6ab Fri, 27 Sep 2024 01:50:06 GMT Expired Expired
505d06e Fri, 27 Sep 2024 06:13:50 GMT Expired Expired
b811f36 Fri, 27 Sep 2024 19:30:25 GMT Expired Expired
57e450a Fri, 27 Sep 2024 20:06:24 GMT Cloud Enterprise

@suejung-sentry suejung-sentry marked this pull request as ready for review September 27, 2024 06:08
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment to take a peak.

@suejung-sentry suejung-sentry added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 02df87c Sep 27, 2024
64 checks passed
@suejung-sentry suejung-sentry deleted the sshin/2281 branch September 27, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.2] Update Gazebo Queries
3 participants