-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add AI features tab at the org level #3185
Conversation
Bundle ReportChanges will increase total bundle size by 31.87kB (0.53%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3185 +/- ##
==========================================
- Coverage 99.06% 98.97% -0.09%
==========================================
Files 798 803 +5
Lines 13966 14012 +46
Branches 3932 3979 +47
==========================================
+ Hits 13836 13869 +33
- Misses 122 134 +12
- Partials 8 9 +1
... and 5 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3185 +/- ##
==========================================
- Coverage 99.06% 98.97% -0.09%
==========================================
Files 798 803 +5
Lines 13966 14012 +46
Branches 3932 3984 +52
==========================================
+ Hits 13836 13869 +33
- Misses 122 134 +12
- Partials 8 9 +1
... and 5 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3185 +/- ##
================================================
- Coverage 99.06000 98.97000 -0.09000
================================================
Files 798 803 +5
Lines 13966 14012 +46
Branches 3963 3979 +16
================================================
+ Hits 13836 13869 +33
- Misses 122 134 +12
- Partials 8 9 +1
... and 5 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 31.87kB (0.53%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3185 +/- ##
==========================================
- Coverage 99.06% 98.97% -0.09%
==========================================
Files 798 803 +5
Lines 13966 14012 +46
Branches 3958 3984 +26
==========================================
+ Hits 13836 13869 +33
- Misses 122 134 +12
- Partials 8 9 +1
... and 5 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
}) | ||
|
||
return ( | ||
<TabNavigation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of repeated components here. I wonder if we can pull it out into a common component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this exactly the same as the Header component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im on board to make it a common component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codecov-ai-reviewer |
</p> | ||
</ExpandableSection.Trigger> | ||
<ExpandableSection.Content> | ||
Screenshot goes here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be an actual thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not have screenshots yet so it will be a follow up
import A from 'ui/A' | ||
import { Card } from 'ui/Card' | ||
|
||
// TODO: Update link to docs once they are available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you already have a ticket for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/pages/CodecovAIPage/CodecovAICommands/CodecovAICommands.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
…v/gazebo into rvinnakota-add-ai-org-tab
Description
This PR introduces some foundational code for the AI features tab on the UI. It will be conditionally rendered based on whether the Codecov AI feature falg is configured or not.
See design here
Follow up work includes:
-> Using the proper screenshots
-> Conditionally rendering a repos table for all repos where AI features are enabled
-> Updated links to the proper docs and GH app
-> Testing all of this
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.