Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add AI features tab at the org level #3185

Merged
merged 18 commits into from
Sep 23, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Sep 11, 2024

Description

This PR introduces some foundational code for the AI features tab on the UI. It will be conditionally rendered based on whether the Codecov AI feature falg is configured or not.

See design here

Follow up work includes:

-> Using the proper screenshots
-> Conditionally rendering a repos table for all repos where AI features are enabled
-> Updated links to the proper docs and GH app
-> Testing all of this

Screenshot 2024-09-18 at 1 17 29 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Sep 11, 2024

Bundle Report

Changes will increase total bundle size by 31.87kB (0.53%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-array-push 6.03MB 31.87kB (0.53%) ⬆️

Copy link

codecov-public-qa bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.97%. Comparing base (0acf455) to head (08d9caf).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3185      +/-   ##
==========================================
- Coverage   99.06%   98.97%   -0.09%     
==========================================
  Files         798      803       +5     
  Lines       13966    14012      +46     
  Branches     3932     3979      +47     
==========================================
+ Hits        13836    13869      +33     
- Misses        122      134      +12     
- Partials        8        9       +1     
Files Coverage Δ
src/App.tsx 97.77% <100.00%> (+0.05%) ⬆️
src/config.js 95.45% <ø> (ø)
.../tabs/OktaAccess/OktaConfigForm/OktaConfigForm.tsx 93.33% <100.00%> (-6.67%) ⬇️
src/pages/AnalyticsPage/Tabs/Tabs.tsx 100.00% <100.00%> (ø)
...ecovAIPage/CodecovAICommands/CodecovAICommands.tsx 100.00% <100.00%> (ø)
src/pages/CodecovAIPage/CodecovAIPage.tsx 100.00% <100.00%> (ø)
...odecovAIPage/InstallCodecovAI/InstallCodecovAI.tsx 100.00% <100.00%> (ø)
...es/CodecovAIPage/LearnMoreBlurb/LearnMoreBlurb.tsx 100.00% <100.00%> (ø)
src/pages/CodecovAIPage/Tabs/Tabs.tsx 60.00% <ø> (ø)
src/pages/MembersPage/Tabs/Tabs.tsx 100.00% <100.00%> (ø)
... and 7 more

... and 5 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.51% <ø> (ø)
Pages 98.72% <98.07%> (-0.18%) ⬇️
Services 99.41% <100.00%> (+<0.01%) ⬆️
Shared 99.65% <ø> (+0.06%) ⬆️
UI 99.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0acf455...08d9caf. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.97%. Comparing base (0acf455) to head (08d9caf).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pages/AccountSettings/shared/Header/Header.tsx 75.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3185      +/-   ##
==========================================
- Coverage   99.06%   98.97%   -0.09%     
==========================================
  Files         798      803       +5     
  Lines       13966    14012      +46     
  Branches     3932     3984      +52     
==========================================
+ Hits        13836    13869      +33     
- Misses        122      134      +12     
- Partials        8        9       +1     
Files with missing lines Coverage Δ
src/App.tsx 97.77% <100.00%> (+0.05%) ⬆️
src/config.js 95.45% <ø> (ø)
.../tabs/OktaAccess/OktaConfigForm/OktaConfigForm.tsx 93.33% <100.00%> (-6.67%) ⬇️
src/pages/AnalyticsPage/Tabs/Tabs.tsx 100.00% <100.00%> (ø)
...ecovAIPage/CodecovAICommands/CodecovAICommands.tsx 100.00% <100.00%> (ø)
src/pages/CodecovAIPage/CodecovAIPage.tsx 100.00% <100.00%> (ø)
...odecovAIPage/InstallCodecovAI/InstallCodecovAI.tsx 100.00% <100.00%> (ø)
...es/CodecovAIPage/LearnMoreBlurb/LearnMoreBlurb.tsx 100.00% <100.00%> (ø)
src/pages/CodecovAIPage/Tabs/Tabs.tsx 60.00% <ø> (ø)
src/pages/MembersPage/Tabs/Tabs.tsx 100.00% <100.00%> (ø)
... and 7 more

... and 5 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.51% <ø> (ø)
Pages 98.72% <98.07%> (-0.18%) ⬇️
Services 99.41% <100.00%> (+<0.01%) ⬆️
Shared 99.65% <ø> (+0.06%) ⬆️
UI 99.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0acf455...08d9caf. Read the comment docs.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.97%. Comparing base (0acf455) to head (08d9caf).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pages/AccountSettings/shared/Header/Header.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3185        +/-   ##
================================================
- Coverage   99.06000   98.97000   -0.09000     
================================================
  Files           798        803         +5     
  Lines         13966      14012        +46     
  Branches       3963       3979        +16     
================================================
+ Hits          13836      13869        +33     
- Misses          122        134        +12     
- Partials          8          9         +1     
Files with missing lines Coverage Δ
src/App.tsx 97.77% <100.00%> (+0.05%) ⬆️
src/config.js 95.45% <ø> (ø)
.../tabs/OktaAccess/OktaConfigForm/OktaConfigForm.tsx 93.33% <100.00%> (-6.67%) ⬇️
src/pages/AnalyticsPage/Tabs/Tabs.tsx 100.00% <100.00%> (ø)
...ecovAIPage/CodecovAICommands/CodecovAICommands.tsx 100.00% <100.00%> (ø)
src/pages/CodecovAIPage/CodecovAIPage.tsx 100.00% <100.00%> (ø)
...odecovAIPage/InstallCodecovAI/InstallCodecovAI.tsx 100.00% <100.00%> (ø)
...es/CodecovAIPage/LearnMoreBlurb/LearnMoreBlurb.tsx 100.00% <100.00%> (ø)
src/pages/CodecovAIPage/Tabs/Tabs.tsx 60.00% <ø> (ø)
src/pages/MembersPage/Tabs/Tabs.tsx 100.00% <100.00%> (ø)
... and 7 more

... and 5 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.51% <ø> (ø)
Pages 98.72% <98.07%> (-0.18%) ⬇️
Services 99.41% <100.00%> (+<0.01%) ⬆️
Shared 99.65% <ø> (+0.06%) ⬆️
UI 99.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0acf455...08d9caf. Read the comment docs.

Copy link

codecov bot commented Sep 11, 2024

Bundle Report

Changes will increase total bundle size by 31.87kB (0.53%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.03MB 31.87kB (0.53%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pages/AccountSettings/shared/Header/Header.tsx 75.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3185      +/-   ##
==========================================
- Coverage   99.06%   98.97%   -0.09%     
==========================================
  Files         798      803       +5     
  Lines       13966    14012      +46     
  Branches     3958     3984      +26     
==========================================
+ Hits        13836    13869      +33     
- Misses        122      134      +12     
- Partials        8        9       +1     
Files with missing lines Coverage Δ
src/App.tsx 97.77% <100.00%> (+0.05%) ⬆️
src/config.js 95.45% <ø> (ø)
.../tabs/OktaAccess/OktaConfigForm/OktaConfigForm.tsx 93.33% <100.00%> (-6.67%) ⬇️
src/pages/AnalyticsPage/Tabs/Tabs.tsx 100.00% <100.00%> (ø)
...ecovAIPage/CodecovAICommands/CodecovAICommands.tsx 100.00% <100.00%> (ø)
src/pages/CodecovAIPage/CodecovAIPage.tsx 100.00% <100.00%> (ø)
...odecovAIPage/InstallCodecovAI/InstallCodecovAI.tsx 100.00% <100.00%> (ø)
...es/CodecovAIPage/LearnMoreBlurb/LearnMoreBlurb.tsx 100.00% <100.00%> (ø)
src/pages/CodecovAIPage/Tabs/Tabs.tsx 60.00% <ø> (ø)
src/pages/MembersPage/Tabs/Tabs.tsx 100.00% <100.00%> (ø)
... and 7 more

... and 5 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.51% <ø> (ø)
Pages 98.72% <98.07%> (-0.18%) ⬇️
Services 99.41% <100.00%> (+<0.01%) ⬆️
Shared 99.65% <ø> (+0.06%) ⬆️
UI 99.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0acf455...08d9caf. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Sep 11, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
99c2afe Wed, 11 Sep 2024 20:15:10 GMT Expired Expired
15240f0 Mon, 16 Sep 2024 16:35:56 GMT Expired Expired
9846e89 Mon, 16 Sep 2024 17:11:25 GMT Expired Expired
9846e89 Mon, 16 Sep 2024 17:13:06 GMT Expired Expired
1e46bdd Tue, 17 Sep 2024 00:07:42 GMT Expired Expired
237fb18 Tue, 17 Sep 2024 14:57:24 GMT Expired Expired
a61c3b5 Wed, 18 Sep 2024 16:25:59 GMT Expired Expired
f79e896 Wed, 18 Sep 2024 17:25:49 GMT Expired Expired
2df62c5 Fri, 20 Sep 2024 14:22:06 GMT Expired Expired
2df62c5 Fri, 20 Sep 2024 14:24:50 GMT Expired Expired
fd76883 Fri, 20 Sep 2024 19:08:14 GMT Expired Expired
08d9caf Mon, 23 Sep 2024 14:59:22 GMT Cloud Enterprise

})

return (
<TabNavigation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of repeated components here. I wonder if we can pull it out into a common component

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this exactly the same as the Header component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im on board to make it a common component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [draft] Add AI features tab at the org level [feat] Add AI features tab at the org level Sep 17, 2024
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review September 17, 2024 14:51
@rohitvinnakota-codecov
Copy link
Contributor Author

@codecov-ai-reviewer

</p>
</ExpandableSection.Trigger>
<ExpandableSection.Content>
Screenshot goes here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be an actual thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have screenshots yet so it will be a follow up

import A from 'ui/A'
import { Card } from 'ui/Card'

// TODO: Update link to docs once they are available
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you already have a ticket for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 42f4e89 Sep 23, 2024
52 of 64 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota-add-ai-org-tab branch September 23, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants