-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add dummy selectors to FailedTestsPage #3188
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## tests-analytics-v2 #3188 +/- ##
======================================================
- Coverage 98.03% 97.85% -0.19%
======================================================
Files 934 934
Lines 14505 14530 +25
Branches 3960 3969 +9
======================================================
- Hits 14220 14218 -2
- Misses 280 307 +27
Partials 5 5
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## tests-analytics-v2 #3188 +/- ##
==========================================================
- Coverage 98.03000 97.85000 -0.18000
==========================================================
Files 934 934
Lines 14505 14530 +25
Branches 3879 3942 +63
==========================================================
- Hits 14220 14218 -2
- Misses 280 307 +27
Partials 5 5
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 7.72kB (0.13%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3188 +/- ##
======================================================
- Coverage 98.03% 97.85% -0.19%
======================================================
Files 934 934
Lines 14505 14530 +25
Branches 3879 3888 +9
======================================================
- Hits 14220 14218 -2
- Misses 280 307 +27
Partials 5 5
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## tests-analytics-v2 #3188 +/- ##
======================================================
- Coverage 98.03% 97.85% -0.19%
======================================================
Files 934 934
Lines 14505 14530 +25
Branches 3960 3969 +9
======================================================
- Hits 14220 14218 -2
- Misses 280 307 +27
Partials 5 5
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Bundle ReportChanges will increase total bundle size by 7.13kB ⬆️
|
Description
This PR just adds the base selectors to the top of the page with some mock data
We also clean up some of the copy on the metrics section to make the wording a little less redundant, as well as marking areas where there is dynamic copy.
Finally, we add the conditional logic to hide the metrics section and other selectors if the user is not on the main branch.
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.