Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add dummy selectors to FailedTestsPage #3188

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Sep 11, 2024

Description

This PR just adds the base selectors to the top of the page with some mock data

We also clean up some of the copy on the metrics section to make the wording a little less redundant, as well as marking areas where there is dynamic copy.

Finally, we add the conditional logic to hide the metrics section and other selectors if the user is not on the main branch.

Screenshots

Screenshot 2024-09-19 at 1 14 16 PM
Screenshot 2024-09-19 at 1 14 23 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 97.85%. Comparing base (ec95735) to head (128d04a).
Report is 1 commits behind head on tests-analytics-v2.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx 0.00% 25 Missing ⚠️

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3188      +/-   ##
======================================================
- Coverage               98.03%   97.85%   -0.19%     
======================================================
  Files                     934      934              
  Lines                   14505    14530      +25     
  Branches                 3960     3969       +9     
======================================================
- Hits                    14220    14218       -2     
- Misses                    280      307      +27     
  Partials                    5        5              
Files with missing lines Coverage Δ
.../FailedTestsPage/BranchSelector/BranchSelector.tsx 100.00% <ø> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 0.00% <ø> (ø)
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.35% <0.00%> (-0.33%) ⬇️
Services 99.41% <ø> (-0.04%) ⬇️
Shared 99.65% <ø> (ø)
UI 94.57% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec95735...128d04a. Read the comment docs.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 97.85%. Comparing base (ec95735) to head (128d04a).
Report is 1 commits behind head on tests-analytics-v2.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx 0.00% 25 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           tests-analytics-v2      #3188        +/-   ##
==========================================================
- Coverage             98.03000   97.85000   -0.18000     
==========================================================
  Files                     934        934                
  Lines                   14505      14530        +25     
  Branches                 3879       3942        +63     
==========================================================
- Hits                    14220      14218         -2     
- Misses                    280        307        +27     
  Partials                    5          5                
Files with missing lines Coverage Δ
.../FailedTestsPage/BranchSelector/BranchSelector.tsx 100.00% <ø> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 0.00% <ø> (ø)
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.35% <0.00%> (-0.33%) ⬇️
Services 99.41% <ø> (-0.04%) ⬇️
Shared 99.65% <ø> (ø)
UI 94.57% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec95735...128d04a. Read the comment docs.

Copy link

codecov bot commented Sep 11, 2024

Bundle Report

Changes will increase total bundle size by 7.72kB (0.13%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.02MB 7.72kB ⬆️

Copy link

codecov-public-qa bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 97.85%. Comparing base (ec95735) to head (128d04a).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3188      +/-   ##
======================================================
- Coverage               98.03%   97.85%   -0.19%     
======================================================
  Files                     934      934              
  Lines                   14505    14530      +25     
  Branches                 3879     3888       +9     
======================================================
- Hits                    14220    14218       -2     
- Misses                    280      307      +27     
  Partials                    5        5              
Files Coverage Δ
.../FailedTestsPage/BranchSelector/BranchSelector.tsx 100.00% <ø> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 0.00% <ø> (ø)
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.35% <0.00%> (-0.33%) ⬇️
Services 99.41% <ø> (-0.04%) ⬇️
Shared 99.65% <ø> (ø)
UI 94.57% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec95735...128d04a. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx 0.00% 25 Missing ⚠️

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3188      +/-   ##
======================================================
- Coverage               98.03%   97.85%   -0.19%     
======================================================
  Files                     934      934              
  Lines                   14505    14530      +25     
  Branches                 3960     3969       +9     
======================================================
- Hits                    14220    14218       -2     
- Misses                    280      307      +27     
  Partials                    5        5              
Files Coverage Δ
.../FailedTestsPage/BranchSelector/BranchSelector.tsx 100.00% <ø> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 0.00% <ø> (ø)
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.35% <0.00%> (-0.33%) ⬇️
Services 99.41% <ø> (-0.04%) ⬇️
Shared 99.65% <ø> (ø)
UI 94.57% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec95735...128d04a. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Sep 11, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
583f8d5 Wed, 11 Sep 2024 23:37:28 GMT Expired Expired
5af88aa Wed, 18 Sep 2024 22:55:56 GMT Expired Expired
1c9eecb Wed, 18 Sep 2024 23:01:39 GMT Expired Expired
128d04a Wed, 18 Sep 2024 23:27:29 GMT Cloud Enterprise

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 7.13kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.02MB 7.13kB ⬆️

@ajay-sentry ajay-sentry merged commit aa8fa23 into tests-analytics-v2 Sep 19, 2024
47 of 59 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/top-flag-selectors branch September 19, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants