Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove old lint rules #3199

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

We had disabled some of these rules a while ago, and everything has been going on smoothly ever since, so we might as well get rid of them once and for all. As well we're getting rid of the nested callback lint rule, as it was being used in the same way as the others and really only hinders development over providing any really meaningful value.

@codecov-staging
Copy link

codecov-staging bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3199   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         936      936           
  Lines       14513    14513           
  Branches     3886     3968   +82     
=======================================
  Hits        14240    14240           
  Misses        268      268           
  Partials        5        5           
Files Coverage Δ
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.83% <ø> (ø)
...ageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx 100.00% <ø> (ø)
src/ui/Dropdown/Dropdown.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.84% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.64% <ø> (ø)
UI 94.56% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36cb00a...5ad9018. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (36cb00a) to head (5ad9018).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3199   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         936      936           
  Lines       14513    14513           
  Branches     3968     3886   -82     
=======================================
  Hits        14240    14240           
  Misses        268      268           
  Partials        5        5           
Files with missing lines Coverage Δ
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.83% <ø> (ø)
...ageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx 100.00% <ø> (ø)
src/ui/Dropdown/Dropdown.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.84% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.64% <ø> (ø)
UI 94.56% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36cb00a...5ad9018. Read the comment docs.

Copy link

codecov-public-qa bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (36cb00a) to head (5ad9018).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3199   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         936      936           
  Lines       14513    14513           
  Branches     3941     3886   -55     
=======================================
  Hits        14240    14240           
  Misses        268      268           
  Partials        5        5           
Files Coverage Δ
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.83% <ø> (ø)
...ageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx 100.00% <ø> (ø)
src/ui/Dropdown/Dropdown.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.84% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.64% <ø> (ø)
UI 94.56% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36cb00a...5ad9018. Read the comment docs.

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

Bundle name Size Change
gazebo-staging-array-push 6.0MB 0 bytes

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (36cb00a) to head (5ad9018).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3199   +/-   ##
===========================================
  Coverage   98.11000   98.11000           
===========================================
  Files           936        936           
  Lines         14513      14513           
  Branches       3968       3941   -27     
===========================================
  Hits          14240      14240           
  Misses          268        268           
  Partials          5          5           
Files with missing lines Coverage Δ
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.83% <ø> (ø)
...ageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx 100.00% <ø> (ø)
src/ui/Dropdown/Dropdown.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.84% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.64% <ø> (ø)
UI 94.56% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36cb00a...5ad9018. Read the comment docs.

Copy link

codecov bot commented Sep 13, 2024

Bundle Report

Bundle size has no change ✅

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
5ad9018 Fri, 13 Sep 2024 17:05:51 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit aeecaee Sep 13, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the chore-remove-old-lint-rules branch September 13, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants