-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove old lint rules #3199
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3199 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 936 936
Lines 14513 14513
Branches 3886 3968 +82
=======================================
Hits 14240 14240
Misses 268 268
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3199 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 936 936
Lines 14513 14513
Branches 3968 3886 -82
=======================================
Hits 14240 14240
Misses 268 268
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3199 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 936 936
Lines 14513 14513
Branches 3941 3886 -55
=======================================
Hits 14240 14240
Misses 268 268
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Bundle ReportBundle size has no change ✅
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3199 +/- ##
===========================================
Coverage 98.11000 98.11000
===========================================
Files 936 936
Lines 14513 14513
Branches 3968 3941 -27
===========================================
Hits 14240 14240
Misses 268 268
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Bundle ReportBundle size has no change ✅ |
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
We had disabled some of these rules a while ago, and everything has been going on smoothly ever since, so we might as well get rid of them once and for all. As well we're getting rid of the nested callback lint rule, as it was being used in the same way as the others and really only hinders development over providing any really meaningful value.