Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing l on cancellation #3205

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: missing l on cancellation #3205

merged 1 commit into from
Sep 17, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Sep 17, 2024

Description

idk why but just saw this file didn't save the additional "l"

Component prop here:

Code Example

Notable Changes

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 1 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.0MB 1 bytes ⬆️

Copy link

codecov bot commented Sep 17, 2024

Bundle Report

Changes will increase total bundle size by 1 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.0MB 1 bytes ⬆️

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (16d3571) to head (a36dbc8).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3205   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         932      932           
  Lines       14478    14478           
  Branches     3875     3875           
=======================================
  Hits        14210    14210           
  Misses        263      263           
  Partials        5        5           
Files Coverage Δ
...PlanPage/subRoutes/DowngradePlan/DowngradePlan.jsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.89% <ø> (-0.02%) ⬇️
Services 99.44% <ø> (+0.03%) ⬆️
Shared 99.65% <ø> (ø)
UI 94.56% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d3571...a36dbc8. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (16d3571) to head (a36dbc8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3205   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         932      932           
  Lines       14478    14478           
  Branches     3956     3956           
=======================================
  Hits        14210    14210           
  Misses        263      263           
  Partials        5        5           
Files with missing lines Coverage Δ
...PlanPage/subRoutes/DowngradePlan/DowngradePlan.jsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.89% <ø> (-0.02%) ⬇️
Services 99.44% <ø> (+0.03%) ⬆️
Shared 99.65% <ø> (ø)
UI 94.56% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d3571...a36dbc8. Read the comment docs.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (16d3571) to head (a36dbc8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3205   +/-   ##
===========================================
  Coverage   98.14000   98.14000           
===========================================
  Files           932        932           
  Lines         14478      14478           
  Branches       3875       3875           
===========================================
  Hits          14210      14210           
  Misses          263        263           
  Partials          5          5           
Files with missing lines Coverage Δ
...PlanPage/subRoutes/DowngradePlan/DowngradePlan.jsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.89% <ø> (-0.02%) ⬇️
Services 99.44% <ø> (+0.03%) ⬆️
Shared 99.65% <ø> (ø)
UI 94.56% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d3571...a36dbc8. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3205   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         932      932           
  Lines       14478    14478           
  Branches     3929     3956   +27     
=======================================
  Hits        14210    14210           
  Misses        263      263           
  Partials        5        5           
Files Coverage Δ
...PlanPage/subRoutes/DowngradePlan/DowngradePlan.jsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.89% <ø> (-0.02%) ⬇️
Services 99.44% <ø> (+0.03%) ⬆️
Shared 99.65% <ø> (ø)
UI 94.56% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d3571...a36dbc8. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
a36dbc8 Tue, 17 Sep 2024 22:37:20 GMT Cloud Enterprise

@ajay-sentry ajay-sentry added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 1e8c05a Sep 17, 2024
62 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/didnt-save-this branch September 17, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants