fix: Move Sunburst logic from recursion to stack based #3206
Conversation
Bundle ReportChanges will increase total bundle size by 122 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 384 bytes ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3206 +/- ##
==========================================
- Coverage 98.15% 98.14% -0.01%
==========================================
Files 932 932
Lines 14473 14480 +7
Branches 3952 3962 +10
==========================================
+ Hits 14206 14212 +6
- Misses 262 263 +1
Partials 5 5
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3206 +/- ##
==========================================
- Coverage 98.15% 98.14% -0.01%
==========================================
Files 932 932
Lines 14473 14480 +7
Branches 3952 3957 +5
==========================================
+ Hits 14206 14212 +6
- Misses 262 263 +1
Partials 5 5
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3206 +/- ##
==========================================
- Coverage 98.15% 98.14% -0.01%
==========================================
Files 932 932
Lines 14473 14480 +7
Branches 3952 3876 -76
==========================================
+ Hits 14206 14212 +6
- Misses 262 263 +1
Partials 5 5
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
nicholas-codecov
deleted the
fix-limit-sunburst-also-off-of-line-count
branch
Description
This PR updates the
selectorMutateused in theSunburstcomponent from recursion to a stack based implementation. This should reduce some overhead for repos with large file counts. I did some rough napkin math and perf tracing on staging with Gazebo's repo and the total call time forselectorMutatewent from2.92msto0.92ms. We don't have a comparable repo to look at that has hundreds of thousands of files, but I think this is a good experiment before lowering the file count.Notable Changes
selectorMutatefunction to a stack based implementation