-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update layouts/LoginLayout to Vitest #3212
chore: Update layouts/LoginLayout to Vitest #3212
Conversation
Bundle ReportBundle size has no change ✅
|
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3212 +/- ##
===========================================
Coverage 99.10000 99.10000
===========================================
Files 799 799
Lines 13975 13975
Branches 3965 3965
===========================================
Hits 13850 13850
Misses 117 117
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
res(ctx.status(200), ctx.data({ me: null })) | ||
) | ||
graphql.query('CurrentUser', (info) => { | ||
return HttpResponse.json({ data: { me: null } }, { status: 200 }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious on why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSW v1 doesn't work with Vitest, and MSW v2 doesn't work with Jest. So as we're migrating we're also moving over to MSW v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which has slightly different syntax
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3212 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 799 799
Lines 13975 13975
Branches 3960 3965 +5
=======================================
Hits 13850 13850
Misses 117 117
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3212 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 799 799
Lines 13975 13975
Branches 3960 3960
=======================================
Hits 13850 13850
Misses 117 117
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3212 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 799 799
Lines 13975 13975
Branches 3965 3965
=======================================
Hits 13850 13850
Misses 117 117
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Description
This PR updates the tests of
layouts/LoginLayout
to VitestNotable Changes
LoginLayout
to Vitest