Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update layouts/LoginLayout to Vitest #3212

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the tests of layouts/LoginLayout to Vitest

Notable Changes

  • Update LoginLayout to Vitest

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

Bundle name Size Change
gazebo-staging-array-push 6.0MB 0 bytes

Copy link

codecov bot commented Sep 19, 2024

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (9d66eb1) to head (2a8ad09).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3212   +/-   ##
===========================================
  Coverage   99.10000   99.10000           
===========================================
  Files           799        799           
  Lines         13975      13975           
  Branches       3965       3965           
===========================================
  Hits          13850      13850           
  Misses          117        117           
  Partials          8          8           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.88% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d66eb1...2a8ad09. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Sep 19, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
ddb41ad Thu, 19 Sep 2024 14:04:37 GMT Expired Expired
2a8ad09 Thu, 19 Sep 2024 14:15:27 GMT Cloud Enterprise

res(ctx.status(200), ctx.data({ me: null }))
)
graphql.query('CurrentUser', (info) => {
return HttpResponse.json({ data: { me: null } }, { status: 200 })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious on why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSW v1 doesn't work with Vitest, and MSW v2 doesn't work with Jest. So as we're migrating we're also moving over to MSW v2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which has slightly different syntax

@codecov-qa
Copy link

codecov-qa bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (9d66eb1) to head (2a8ad09).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3212   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         799      799           
  Lines       13975    13975           
  Branches     3960     3965    +5     
=======================================
  Hits        13850    13850           
  Misses        117      117           
  Partials        8        8           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.88% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d66eb1...2a8ad09. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3212   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         799      799           
  Lines       13975    13975           
  Branches     3960     3960           
=======================================
  Hits        13850    13850           
  Misses        117      117           
  Partials        8        8           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.88% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d66eb1...2a8ad09. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (9d66eb1) to head (2a8ad09).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3212   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         799      799           
  Lines       13975    13975           
  Branches     3965     3965           
=======================================
  Hits        13850    13850           
  Misses        117      117           
  Partials        8        8           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.88% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d66eb1...2a8ad09. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 82fa7ae Sep 19, 2024
64 checks passed
@nicholas-codecov nicholas-codecov deleted the chore-update-layouts-login-layout-to-vitest branch September 19, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants