Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update layouts/shared tests to Vitest #3214

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the tests in the layouts/shared directory to Vitest

Notable Changes

  • Update ErrorBoundary
  • Update NetworkErrorBoundary
  • Update networkErrorMetrics
  • Update SilentNetworkError
  • Update SilentNetworkErrorWrapper

Copy link

codecov bot commented Sep 19, 2024

Bundle Report

Changes will decrease total bundle size by 22 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.0MB 22 bytes (-0.0%) ⬇️

@codecov-staging
Copy link

Bundle Report

Changes will decrease total bundle size by 22 bytes ⬇️

Bundle name Size Change
gazebo-staging-array-push 6.0MB 22 bytes ⬇️

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (82fa7ae) to head (ae54ac6).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3214   +/-   ##
===========================================
  Coverage   99.06000   99.06000           
===========================================
  Files           799        798    -1     
  Lines         13975      13965   -10     
  Branches       3879       3958   +79     
===========================================
- Hits          13845      13835   -10     
  Misses          122        122           
  Partials          8          8           
Files with missing lines Coverage Δ
...tNetworkErrorWrapper/SilentNetworkErrorWrapper.tsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.51% <100.00%> (-0.05%) ⬇️
Pages 98.89% <ø> (+0.01%) ⬆️
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.18% <ø> (-0.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82fa7ae...ae54ac6. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (82fa7ae) to head (ae54ac6).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3214      +/-   ##
==========================================
- Coverage   99.06%   99.06%   -0.01%     
==========================================
  Files         799      798       -1     
  Lines       13975    13965      -10     
  Branches     3960     3963       +3     
==========================================
- Hits        13845    13835      -10     
  Misses        122      122              
  Partials        8        8              
Files with missing lines Coverage Δ
...tNetworkErrorWrapper/SilentNetworkErrorWrapper.tsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.51% <100.00%> (-0.05%) ⬇️
Pages 98.89% <ø> (+0.01%) ⬆️
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.18% <ø> (-0.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82fa7ae...ae54ac6. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3214      +/-   ##
==========================================
- Coverage   99.06%   99.06%   -0.01%     
==========================================
  Files         799      798       -1     
  Lines       13975    13965      -10     
  Branches     3965     3958       -7     
==========================================
- Hits        13845    13835      -10     
  Misses        122      122              
  Partials        8        8              
Files Coverage Δ
...tNetworkErrorWrapper/SilentNetworkErrorWrapper.tsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.51% <100.00%> (-0.05%) ⬇️
Pages 98.89% <ø> (+0.01%) ⬆️
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.18% <ø> (-0.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82fa7ae...ae54ac6. Read the comment docs.

Copy link

codecov-public-qa bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (82fa7ae) to head (ae54ac6).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3214      +/-   ##
==========================================
- Coverage   99.06%   99.06%   -0.01%     
==========================================
  Files         799      798       -1     
  Lines       13975    13965      -10     
  Branches     3879     3963      +84     
==========================================
- Hits        13845    13835      -10     
  Misses        122      122              
  Partials        8        8              
Files Coverage Δ
...tNetworkErrorWrapper/SilentNetworkErrorWrapper.tsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.51% <100.00%> (-0.05%) ⬇️
Pages 98.89% <ø> (+0.01%) ⬆️
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.18% <ø> (-0.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82fa7ae...ae54ac6. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
f45c024 Thu, 19 Sep 2024 14:59:13 GMT Cloud Enterprise

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send it!

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 1ff723b Sep 20, 2024
62 of 63 checks passed
@nicholas-codecov nicholas-codecov deleted the chore-update-layouts-shared-tests-to-vitest branch September 20, 2024 17:20
Copy link

sentry-io bot commented Sep 27, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SyntaxError: Unexpected token '<', "<!doctype "... is not valid JSON /:provider/:owner/:repo/pull/:pullId View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants