Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Vitest config tweaks #3222

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR fixes some linting issues with Vitest, and we no longer have to import vi only for JS files.

Copy link

codecov bot commented Sep 20, 2024

Bundle Report

Bundle size has no change ✅

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

Bundle name Size Change
gazebo-staging-array-push 6.0MB 0 bytes

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (0ecb48e) to head (d5b855e).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3222      +/-   ##
==========================================
- Coverage   99.07%   99.06%   -0.01%     
==========================================
  Files         798      798              
  Lines       13964    13964              
  Branches     3958     3958              
==========================================
- Hits        13835    13834       -1     
- Misses        121      122       +1     
  Partials        8        8              

see 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.50% <ø> (ø)
Pages 98.88% <ø> (-0.02%) ⬇️
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ecb48e...d5b855e. Read the comment docs.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (0ecb48e) to head (d5b855e).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3222        +/-   ##
================================================
- Coverage   99.07000   99.06000   -0.01000     
================================================
  Files           798        798                
  Lines         13964      13964                
  Branches       3958       3931        -27     
================================================
- Hits          13835      13834         -1     
- Misses          121        122         +1     
  Partials          8          8                

see 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.50% <ø> (ø)
Pages 98.88% <ø> (-0.02%) ⬇️
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ecb48e...d5b855e. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3222      +/-   ##
==========================================
- Coverage   99.07%   99.06%   -0.01%     
==========================================
  Files         798      798              
  Lines       13964    13964              
  Branches     3958     3958              
==========================================
- Hits        13835    13834       -1     
- Misses        121      122       +1     
  Partials        8        8              

see 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.50% <ø> (ø)
Pages 98.88% <ø> (-0.02%) ⬇️
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ecb48e...d5b855e. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (0ecb48e) to head (d5b855e).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3222      +/-   ##
==========================================
- Coverage   99.07%   99.06%   -0.01%     
==========================================
  Files         798      798              
  Lines       13964    13964              
  Branches     3958     3878      -80     
==========================================
- Hits        13835    13834       -1     
- Misses        121      122       +1     
  Partials        8        8              

see 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.50% <ø> (ø)
Pages 98.88% <ø> (-0.02%) ⬇️
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ecb48e...d5b855e. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
d5b855e Fri, 20 Sep 2024 10:42:30 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 51d9957 Sep 20, 2024
63 of 64 checks passed
@nicholas-codecov nicholas-codecov deleted the some-more-vitest-config-tweaking branch September 20, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants