Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tokenless section in global upload token tab #3223

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

RulaKhaled
Copy link
Contributor

@RulaKhaled RulaKhaled commented Sep 20, 2024

Description

No api work, tokenless section in global upload token, hidden behind a feature flag.

Notable Changes

  • New modal for required token
  • New component for the radio buttons of tokenless

Screenshots

Screenshot 2024-09-20 at 1 46 48 PM
Screenshot 2024-09-20 at 1 46 43 PM
Screenshot 2024-09-20 at 1 46 39 PM

issue: [Frontend] Add new toggle switch to org settings page

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@RulaKhaled RulaKhaled marked this pull request as ready for review September 20, 2024 11:50
@codecov-staging
Copy link

codecov-staging bot commented Sep 20, 2024

Bundle Report

Changes will increase total bundle size by 10.87kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.01MB 10.87kB ⬆️

Copy link

codecov bot commented Sep 20, 2024

Bundle Report

Changes will increase total bundle size by 10.84kB (0.18%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.01MB 10.84kB (0.18%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (8057aba) to head (83dd7ae).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3223      +/-   ##
==========================================
- Coverage   98.14%   97.96%   -0.18%     
==========================================
  Files         932      931       -1     
  Lines       14482    14500      +18     
  Branches     3958     3886      -72     
==========================================
- Hits        14213    14205       -8     
- Misses        264      287      +23     
- Partials        5        8       +3     
Files with missing lines Coverage Δ
...untSettings/tabs/OrgUploadToken/OrgUploadToken.jsx 100.00% <100.00%> (ø)
...ploadToken/TokenlessSection/TokenRequiredModal.tsx 100.00% <100.00%> (ø)
...gUploadToken/TokenlessSection/TokenlessSection.tsx 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

Components Coverage Δ
Assets 53.65% <ø> (+0.17%) ⬆️
Layouts 97.37% <ø> (-1.50%) ⬇️
Pages 98.78% <100.00%> (-0.12%) ⬇️
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (-0.07%) ⬇️
UI 94.03% <ø> (-0.54%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8057aba...83dd7ae. Read the comment docs.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (8057aba) to head (83dd7ae).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3223        +/-   ##
================================================
- Coverage   98.14000   97.96000   -0.18000     
================================================
  Files           932        931         -1     
  Lines         14482      14500        +18     
  Branches       3877       3886         +9     
================================================
- Hits          14213      14205         -8     
- Misses          264        287        +23     
- Partials          5          8         +3     
Files with missing lines Coverage Δ
...untSettings/tabs/OrgUploadToken/OrgUploadToken.jsx 100.00% <100.00%> (ø)
...ploadToken/TokenlessSection/TokenRequiredModal.tsx 100.00% <100.00%> (ø)
...gUploadToken/TokenlessSection/TokenlessSection.tsx 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

Components Coverage Δ
Assets 53.65% <ø> (+0.17%) ⬆️
Layouts 97.37% <ø> (-1.50%) ⬇️
Pages 98.78% <100.00%> (-0.12%) ⬇️
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (-0.07%) ⬇️
UI 94.03% <ø> (-0.54%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8057aba...83dd7ae. Read the comment docs.

Copy link

codecov-public-qa bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (8057aba) to head (83dd7ae).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3223      +/-   ##
==========================================
- Coverage   98.14%   97.96%   -0.18%     
==========================================
  Files         932      931       -1     
  Lines       14482    14500      +18     
  Branches     3958     3966       +8     
==========================================
- Hits        14213    14205       -8     
- Misses        264      287      +23     
- Partials        5        8       +3     
Files Coverage Δ
...untSettings/tabs/OrgUploadToken/OrgUploadToken.jsx 100.00% <100.00%> (ø)
...ploadToken/TokenlessSection/TokenRequiredModal.tsx 100.00% <100.00%> (ø)
...gUploadToken/TokenlessSection/TokenlessSection.tsx 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

Components Coverage Δ
Assets 53.65% <ø> (+0.17%) ⬆️
Layouts 97.37% <ø> (-1.50%) ⬇️
Pages 98.78% <100.00%> (-0.12%) ⬇️
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (-0.07%) ⬇️
UI 94.03% <ø> (-0.54%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8057aba...83dd7ae. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3223      +/-   ##
==========================================
- Coverage   98.14%   97.96%   -0.18%     
==========================================
  Files         932      931       -1     
  Lines       14482    14500      +18     
  Branches     3958     3886      -72     
==========================================
- Hits        14213    14205       -8     
- Misses        264      287      +23     
- Partials        5        8       +3     
Files Coverage Δ
...untSettings/tabs/OrgUploadToken/OrgUploadToken.jsx 100.00% <100.00%> (ø)
...ploadToken/TokenlessSection/TokenRequiredModal.tsx 100.00% <100.00%> (ø)
...gUploadToken/TokenlessSection/TokenlessSection.tsx 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

Components Coverage Δ
Assets 53.65% <ø> (+0.17%) ⬆️
Layouts 97.37% <ø> (-1.50%) ⬇️
Pages 98.78% <100.00%> (-0.12%) ⬇️
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (-0.07%) ⬇️
UI 94.03% <ø> (-0.54%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8057aba...83dd7ae. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Sep 20, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
7eb05d8 Fri, 20 Sep 2024 11:54:48 GMT Expired Expired
ccc35ef Fri, 20 Sep 2024 12:52:11 GMT Expired Expired
9540f19 Fri, 20 Sep 2024 13:09:16 GMT Expired Expired
05eb7cf Fri, 20 Sep 2024 13:24:20 GMT Expired Expired
83dd7ae Fri, 20 Sep 2024 13:32:27 GMT Cloud Enterprise

@RulaKhaled RulaKhaled marked this pull request as draft September 20, 2024 12:49
@RulaKhaled RulaKhaled marked this pull request as ready for review September 20, 2024 13:27
@RulaKhaled RulaKhaled marked this pull request as draft September 20, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants