-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove unused manual cleanups from tests #3224
base: main
Are you sure you want to change the base?
Conversation
f8cd48b
to
d3cad7d
Compare
Bundle ReportBundle size has no change ✅
|
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3224 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 798 798
Lines 13964 13964
Branches 3958 3958
=======================================
+ Hits 13833 13834 +1
+ Misses 123 122 -1
Partials 8 8 see 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3224 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 798 798
Lines 13964 13964
Branches 3963 3963
=======================================
+ Hits 13833 13834 +1
+ Misses 123 122 -1
Partials 8 8 see 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3224 +/- ##
===========================================
Coverage 99.06000 99.06000
===========================================
Files 798 798
Lines 13964 13964
Branches 3963 3878 -85
===========================================
+ Hits 13833 13834 +1
+ Misses 123 122 -1
Partials 8 8 see 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3224 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 798 798
Lines 13964 13964
Branches 3963 3931 -32
=======================================
+ Hits 13833 13834 +1
+ Misses 123 122 -1
Partials 8 8 see 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you love to see it!
I did have to leave that one in there 😢 ... though I haven't run into that case before |
Description
Got things working without needing manual cleanup in tests, this PR just removes them from PRs that have already been merged