chore: Update pages/AccountSettings to Vitest #3227
Conversation
Bundle ReportChanges will increase total bundle size by 55 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 55 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
| const eyeIcon = await screen.findByRole('button', { | ||
| name: /eye/, | ||
| }) | ||
| const eyeIcon = await screen.findByTestId('toggle-password') |
There was a problem hiding this comment.
nit: is this variable name and at line 155 still accurate/helpful now that we're not finding by "eye"?
There was a problem hiding this comment.
Ahh, just reached the next file. The eye is still in there. Oh well, feel free to just leave as is
| }) | ||
| ) | ||
|
|
||
| return { addNotification, mutate, user } | ||
| } | ||
|
|
||
| describe('renders component', () => { | ||
| beforeEach(() => { |
There was a problem hiding this comment.
from my own curiosity: what's the thinking behind swapping this out in favor of adding to each test?
There was a problem hiding this comment.
So imo this gives us better overall control for each individual test, and narrows down potential issues with test setups. It also makes it easier to grab mocks or user events that we setup in the setup functions as well, and future proofs it for any of those cases.
nicholas-codecov
deleted the
chore-update-pages-account-settings-to-vitest
branch
Description
This PR updates all the tests within the
pages/AccountSettingsto Vitest