Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: refactor page components into separate sections #3231

Open
wants to merge 1 commit into
base: tests-analytics-v2
Choose a base branch
from

Conversation

ajay-sentry
Copy link
Contributor

Description

This PR aims to do a slight refactor of our page components, splitting things out into respective chunks that we can build on top of later.

This PR also writes a simple UT for the failed tests page confirming all the components are on the page

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes missing coverage. Please review.

Project coverage is 97.88%. Comparing base (555e411) to head (60a2cf8).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% 24 Missing ⚠️
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 12.50% 7 Missing ⚠️

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3231      +/-   ##
======================================================
+ Coverage               97.72%   97.88%   +0.16%     
======================================================
  Files                     931      935       +4     
  Lines                   14522    14538      +16     
  Branches                 3974     3942      -32     
======================================================
+ Hits                    14192    14231      +39     
+ Misses                    322      302      -20     
+ Partials                    8        5       -3     
Files with missing lines Coverage Δ
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx 100.00% <ø> (+100.00%) ⬆️
.../SelectorSection/BranchSelector/BranchSelector.tsx 100.00% <ø> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 40.00% <12.50%> (-12.95%) ⬇️
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (-0.18%) ⬇️
Layouts 98.87% <ø> (+1.49%) ⬆️
Pages 98.41% <3.12%> (+0.06%) ⬆️
Services 99.44% <ø> (+0.03%) ⬆️
Shared 99.65% <ø> (+0.06%) ⬆️
UI 94.57% <ø> (+0.53%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555e411...60a2cf8. Read the comment docs.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes missing coverage. Please review.

Project coverage is 97.88%. Comparing base (555e411) to head (60a2cf8).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% 24 Missing ⚠️
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 12.50% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           tests-analytics-v2      #3231        +/-   ##
==========================================================
+ Coverage             97.72000   97.88000   +0.16000     
==========================================================
  Files                     931        935         +4     
  Lines                   14522      14538        +16     
  Branches                 3969       3888        -81     
==========================================================
+ Hits                    14192      14231        +39     
+ Misses                    322        302        -20     
+ Partials                    8          5         -3     
Files with missing lines Coverage Δ
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx 100.00% <ø> (+100.00%) ⬆️
.../SelectorSection/BranchSelector/BranchSelector.tsx 100.00% <ø> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 40.00% <12.50%> (-12.95%) ⬇️
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (-0.18%) ⬇️
Layouts 98.87% <ø> (+1.49%) ⬆️
Pages 98.41% <3.12%> (+0.06%) ⬆️
Services 99.44% <ø> (+0.03%) ⬆️
Shared 99.65% <ø> (+0.06%) ⬆️
UI 94.57% <ø> (+0.53%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555e411...60a2cf8. Read the comment docs.

Copy link

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes missing coverage. Please review.

Project coverage is 97.88%. Comparing base (555e411) to head (60a2cf8).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3231      +/-   ##
======================================================
+ Coverage               97.72%   97.88%   +0.16%     
======================================================
  Files                     931      935       +4     
  Lines                   14522    14538      +16     
  Branches                 3969     3974       +5     
======================================================
+ Hits                    14192    14231      +39     
+ Misses                    322      302      -20     
+ Partials                    8        5       -3     
Files Coverage Δ
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx 100.00% <ø> (+100.00%) ⬆️
.../SelectorSection/BranchSelector/BranchSelector.tsx 100.00% <ø> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 40.00% <12.50%> (-12.95%) ⬇️
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (-0.18%) ⬇️
Layouts 98.87% <ø> (+1.49%) ⬆️
Pages 98.41% <3.12%> (+0.06%) ⬆️
Services 99.44% <ø> (+0.03%) ⬆️
Shared 99.65% <ø> (+0.06%) ⬆️
UI 94.57% <ø> (+0.53%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555e411...60a2cf8. Read the comment docs.

@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% 24 Missing ⚠️
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 12.50% 7 Missing ⚠️

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3231      +/-   ##
======================================================
+ Coverage               97.72%   97.88%   +0.16%     
======================================================
  Files                     931      935       +4     
  Lines                   14522    14538      +16     
  Branches                 3969     3969              
======================================================
+ Hits                    14192    14231      +39     
+ Misses                    322      302      -20     
+ Partials                    8        5       -3     
Files Coverage Δ
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx 100.00% <ø> (+100.00%) ⬆️
.../SelectorSection/BranchSelector/BranchSelector.tsx 100.00% <ø> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 40.00% <12.50%> (-12.95%) ⬇️
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (-0.18%) ⬇️
Layouts 98.87% <ø> (+1.49%) ⬆️
Pages 98.41% <3.12%> (+0.06%) ⬆️
Services 99.44% <ø> (+0.03%) ⬆️
Shared 99.65% <ø> (+0.06%) ⬆️
UI 94.57% <ø> (+0.53%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555e411...60a2cf8. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
60a2cf8 Fri, 20 Sep 2024 21:19:36 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants