-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: refactor page components into separate sections #3231
base: tests-analytics-v2
Are you sure you want to change the base?
ref: refactor page components into separate sections #3231
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## tests-analytics-v2 #3231 +/- ##
======================================================
+ Coverage 97.72% 97.88% +0.16%
======================================================
Files 931 935 +4
Lines 14522 14538 +16
Branches 3974 3942 -32
======================================================
+ Hits 14192 14231 +39
+ Misses 322 302 -20
+ Partials 8 5 -3
... and 21 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## tests-analytics-v2 #3231 +/- ##
==========================================================
+ Coverage 97.72000 97.88000 +0.16000
==========================================================
Files 931 935 +4
Lines 14522 14538 +16
Branches 3969 3888 -81
==========================================================
+ Hits 14192 14231 +39
+ Misses 322 302 -20
+ Partials 8 5 -3
... and 21 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3231 +/- ##
======================================================
+ Coverage 97.72% 97.88% +0.16%
======================================================
Files 931 935 +4
Lines 14522 14538 +16
Branches 3969 3974 +5
======================================================
+ Hits 14192 14231 +39
+ Misses 322 302 -20
+ Partials 8 5 -3
... and 21 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## tests-analytics-v2 #3231 +/- ##
======================================================
+ Coverage 97.72% 97.88% +0.16%
======================================================
Files 931 935 +4
Lines 14522 14538 +16
Branches 3969 3969
======================================================
+ Hits 14192 14231 +39
+ Misses 322 302 -20
+ Partials 8 5 -3
... and 21 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This PR aims to do a slight refactor of our page components, splitting things out into respective chunks that we can build on top of later.
This PR also writes a simple UT for the failed tests page confirming all the components are on the page
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.