Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore update ui/Summary to TS and Vitest #3236

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Chore update ui/Summary to TS and Vitest #3236

merged 5 commits into from
Sep 26, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR refactors all the code in ui/Summary to TypeScript and updates all the tests to Vitest.

@codecov-staging
Copy link

codecov-staging bot commented Sep 22, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 16 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-array-push 6.04MB 16 bytes (0.0%) ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Sep 22, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
cfef44f Sun, 22 Sep 2024 13:31:02 GMT Expired Expired
b72e712 Thu, 26 Sep 2024 17:19:33 GMT Cloud Enterprise

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.84%. Comparing base (7dc3361) to head (fbf167a).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3236      +/-   ##
==========================================
- Coverage   98.85%   98.84%   -0.01%     
==========================================
  Files         803      803              
  Lines       14028    14028              
  Branches     3990     3998       +8     
==========================================
- Hits        13867    13866       -1     
  Misses        153      153              
- Partials        8        9       +1
Files Coverage Δ
src/ui/Summary/SummaryRoot/SummaryRoot.tsx 100.00% <100.00%> (ø)
src/ui/Summary/Summary.tsx 91.66% <91.66%> (ø)
src/ui/Summary/SummaryField/SummaryField.tsx 83.33% <75.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (ø)
Pages 98.66% <ø> (+0.01%) ⬆️
Services 99.41% <ø> (ø)
Shared 99.23% <ø> (ø)
UI 98.59% <88.23%> (-0.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc3361...fbf167a. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/ui/Summary/Summary.tsx 91.66% 1 Missing ⚠️
src/ui/Summary/SummaryField/SummaryField.tsx 75.00% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3236      +/-   ##
==========================================
- Coverage   98.85%   98.84%   -0.01%     
==========================================
  Files         803      803              
  Lines       14028    14028              
  Branches     3990     3993       +3     
==========================================
- Hits        13867    13866       -1     
  Misses        153      153              
- Partials        8        9       +1
Files with missing lines Coverage Δ
src/ui/Summary/SummaryRoot/SummaryRoot.tsx 100.00% <100.00%> (ø)
src/ui/Summary/Summary.tsx 91.66% <91.66%> (ø)
src/ui/Summary/SummaryField/SummaryField.tsx 83.33% <75.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (ø)
Pages 98.66% <ø> (+0.01%) ⬆️
Services 99.41% <ø> (ø)
Shared 99.23% <ø> (ø)
UI 98.59% <88.23%> (-0.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc3361...fbf167a. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024

Bundle Report

Changes will increase total bundle size by 16 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.04MB 16 bytes (0.0%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.84%. Comparing base (7dc3361) to head (fbf167a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/ui/Summary/Summary.tsx 91.66% 1 Missing ⚠️
src/ui/Summary/SummaryField/SummaryField.tsx 75.00% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3236      +/-   ##
==========================================
- Coverage   98.85%   98.84%   -0.01%     
==========================================
  Files         803      803              
  Lines       14028    14028              
  Branches     3990     3993       +3     
==========================================
- Hits        13867    13866       -1     
  Misses        153      153              
- Partials        8        9       +1
Files with missing lines Coverage Δ
src/ui/Summary/SummaryRoot/SummaryRoot.tsx 100.00% <100.00%> (ø)
src/ui/Summary/Summary.tsx 91.66% <91.66%> (ø)
src/ui/Summary/SummaryField/SummaryField.tsx 83.33% <75.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (ø)
Pages 98.66% <ø> (+0.01%) ⬆️
Services 99.41% <ø> (ø)
Shared 99.23% <ø> (ø)
UI 98.59% <88.23%> (-0.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc3361...fbf167a. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Sep 26, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.84%. Comparing base (7dc3361) to head (fbf167a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/ui/Summary/Summary.tsx 91.66% 1 Missing ⚠️
src/ui/Summary/SummaryField/SummaryField.tsx 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3236        +/-   ##
================================================
- Coverage   98.85000   98.84000   -0.01000     
================================================
  Files           803        803                
  Lines         14028      14028                
  Branches       3990       3998         +8     
================================================
- Hits          13867      13866         -1     
  Misses          153        153                
- Partials          8          9         +1
Files with missing lines Coverage Δ
src/ui/Summary/SummaryRoot/SummaryRoot.tsx 100.00% <100.00%> (ø)
src/ui/Summary/Summary.tsx 91.66% <91.66%> (ø)
src/ui/Summary/SummaryField/SummaryField.tsx 83.33% <75.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (ø)
Pages 98.66% <ø> (+0.01%) ⬆️
Services 99.41% <ø> (ø)
Shared 99.23% <ø> (ø)
UI 98.59% <88.23%> (-0.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc3361...fbf167a. Read the comment docs.

Merged via the queue into main with commit a9860b1 Sep 26, 2024
53 of 63 checks passed
@nicholas-codecov nicholas-codecov deleted the chore-update-summary-to-vitest branch September 26, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov spalmurray-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @spalmurray-codecov