Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove dark mode feature flag #3237

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

suejung-sentry
Copy link
Contributor

Remove flag for dark mode as it is now at 100% and stable

Closes codecov/engineering-team#2472

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (42f4e89) to head (bc7d181).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3237   +/-   ##
===========================================
  Coverage   98.97000   98.97000           
===========================================
  Files           803        803           
  Lines         14012      14008    -4     
  Branches       3900       3982   +82     
===========================================
- Hits          13869      13865    -4     
  Misses          134        134           
  Partials          9          9           
Files with missing lines Coverage Δ
src/layouts/Header/Header.tsx 84.61% <ø> (-2.06%) ⬇️
...outs/Header/components/GuestHeader/GuestHeader.tsx 90.00% <ø> (-1.67%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (-0.02%) ⬇️
Pages 98.72% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.65% <ø> (ø)
UI 99.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f4e89...bc7d181. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3237      +/-   ##
==========================================
- Coverage   98.97%   98.97%   -0.01%     
==========================================
  Files         803      803              
  Lines       14012    14008       -4     
  Branches     3984     3977       -7     
==========================================
- Hits        13869    13865       -4     
  Misses        134      134              
  Partials        9        9              
Files with missing lines Coverage Δ
src/layouts/Header/Header.tsx 84.61% <ø> (-2.06%) ⬇️
...outs/Header/components/GuestHeader/GuestHeader.tsx 90.00% <ø> (-1.67%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (-0.02%) ⬇️
Pages 98.72% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.65% <ø> (ø)
UI 99.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f4e89...bc7d181. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (42f4e89) to head (bc7d181).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3237      +/-   ##
==========================================
- Coverage   98.97%   98.97%   -0.01%     
==========================================
  Files         803      803              
  Lines       14012    14008       -4     
  Branches     3900     3982      +82     
==========================================
- Hits        13869    13865       -4     
  Misses        134      134              
  Partials        9        9              
Files with missing lines Coverage Δ
src/layouts/Header/Header.tsx 84.61% <ø> (-2.06%) ⬇️
...outs/Header/components/GuestHeader/GuestHeader.tsx 90.00% <ø> (-1.67%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (-0.02%) ⬇️
Pages 98.72% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.65% <ø> (ø)
UI 99.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f4e89...bc7d181. Read the comment docs.

Copy link

codecov-public-qa bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (42f4e89) to head (bc7d181).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3237      +/-   ##
==========================================
- Coverage   98.97%   98.97%   -0.01%     
==========================================
  Files         803      803              
  Lines       14012    14008       -4     
  Branches     3900     3977      +77     
==========================================
- Hits        13869    13865       -4     
  Misses        134      134              
  Partials        9        9              
Files Coverage Δ
src/layouts/Header/Header.tsx 84.61% <ø> (-2.06%) ⬇️
...outs/Header/components/GuestHeader/GuestHeader.tsx 90.00% <ø> (-1.67%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (-0.02%) ⬇️
Pages 98.72% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.65% <ø> (ø)
UI 99.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f4e89...bc7d181. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Sep 23, 2024

Bundle Report

Changes will decrease total bundle size by 89 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-array-push 6.03MB 89 bytes (-0.0%) ⬇️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Sep 23, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
5d00557 Mon, 23 Sep 2024 03:19:05 GMT Expired Expired
d32da95 Mon, 23 Sep 2024 03:29:41 GMT Expired Expired
bc7d181 Mon, 23 Sep 2024 15:53:07 GMT Cloud Enterprise

@suejung-sentry suejung-sentry added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 4068521 Sep 23, 2024
64 checks passed
@suejung-sentry suejung-sentry deleted the sshin/remove-ff-darkmode branch September 23, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Launch Darkly Feature Flag for Dark Mode
3 participants