feat: Add search and filter to Uploads list #3349

spalmurray-codecov · 2024-10-03T16:08:26Z

Adds some basic client-side search and filter functionality to the uploads list. Also updates the order of uploads to put the most recent at the top (was shocked to realize we don't do this lol). The flags error message in designs is coming in a later issue. Have tested keyboard navigation for all these new elements.

Designs
Closes codecov/engineering-team#1128

codecov-qa · 2024-10-03T16:11:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (b6964b9) to head (f4e33f8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3349      +/-   ##
==========================================
+ Coverage   99.12%   99.17%   +0.04%     
==========================================
  Files         800      799       -1     
  Lines       14016    14093      +77     
  Branches     3856     3882      +26     
==========================================
+ Hits        13894    13977      +83     
+ Misses        113      107       -6     
  Partials        9        9

Files with missing lines	Coverage Δ
...ailPage/CommitCoverage/UploadsCard/RenderError.tsx	`100.00% <100.00%> (ø)`
...tailPage/CommitCoverage/UploadsCard/UploadItem.tsx	`100.00% <100.00%> (ø)`
...age/CommitCoverage/UploadsCard/UploadReference.tsx	`100.00% <100.00%> (ø)`
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	`100.00% <100.00%> (ø)`
...ommitCoverage/UploadsCard/useUploads/useUploads.ts	`100.00% <100.00%> (ø)`
src/services/commit/useCommit.tsx	`100.00% <100.00%> (ø)`
src/shared/utils/commit.ts	`100.00% <100.00%> (ø)`
src/shared/utils/extractUploads.ts	`100.00% <100.00%> (+6.38%)`	⬆️
src/ui/SearchField/SearchField.jsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.97% <100.00%> (+<0.01%)`	⬆️
Services	`99.44% <100.00%> (+<0.01%)`	⬆️
Shared	`99.80% <100.00%> (+0.21%)`	⬆️
UI	`99.10% <100.00%> (+0.20%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6964b9...f4e33f8. Read the comment docs.

codecov-public-qa · 2024-10-03T16:11:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (b6964b9) to head (f4e33f8).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3349      +/-   ##
==========================================
+ Coverage   99.12%   99.17%   +0.04%     
==========================================
  Files         800      799       -1     
  Lines       14016    14093      +77     
  Branches     3856     3882      +26     
==========================================
+ Hits        13894    13977      +83     
+ Misses        113      107       -6     
  Partials        9        9

Files	Coverage Δ
...ailPage/CommitCoverage/UploadsCard/RenderError.tsx	`100.00% <100.00%> (ø)`
...tailPage/CommitCoverage/UploadsCard/UploadItem.tsx	`100.00% <100.00%> (ø)`
...age/CommitCoverage/UploadsCard/UploadReference.tsx	`100.00% <100.00%> (ø)`
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	`100.00% <100.00%> (ø)`
...ommitCoverage/UploadsCard/useUploads/useUploads.ts	`100.00% <100.00%> (ø)`
src/services/commit/useCommit.tsx	`100.00% <100.00%> (ø)`
src/shared/utils/commit.ts	`100.00% <100.00%> (ø)`
src/shared/utils/extractUploads.ts	`100.00% <100.00%> (+6.38%)`	⬆️
src/ui/SearchField/SearchField.jsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.97% <100.00%> (+<0.01%)`	⬆️
Services	`99.44% <100.00%> (+<0.01%)`	⬆️
Shared	`99.80% <100.00%> (+0.21%)`	⬆️
UI	`99.10% <100.00%> (+0.20%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6964b9...f4e33f8. Read the comment docs.

codecov-notifications · 2024-10-03T16:11:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3349      +/-   ##
==========================================
+ Coverage   99.12%   99.17%   +0.04%     
==========================================
  Files         800      799       -1     
  Lines       14016    14093      +77     
  Branches     3851     3882      +31     
==========================================
+ Hits        13894    13977      +83     
+ Misses        113      107       -6     
  Partials        9        9

Files with missing lines	Coverage Δ
...ailPage/CommitCoverage/UploadsCard/RenderError.tsx	`100.00% <100.00%> (ø)`
...tailPage/CommitCoverage/UploadsCard/UploadItem.tsx	`100.00% <100.00%> (ø)`
...age/CommitCoverage/UploadsCard/UploadReference.tsx	`100.00% <100.00%> (ø)`
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	`100.00% <100.00%> (ø)`
...ommitCoverage/UploadsCard/useUploads/useUploads.ts	`100.00% <100.00%> (ø)`
src/services/commit/useCommit.tsx	`100.00% <100.00%> (ø)`
src/shared/utils/commit.ts	`100.00% <100.00%> (ø)`
src/shared/utils/extractUploads.ts	`100.00% <100.00%> (+6.38%)`	⬆️
src/ui/SearchField/SearchField.jsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.97% <100.00%> (+<0.01%)`	⬆️
Services	`99.44% <100.00%> (+<0.01%)`	⬆️
Shared	`99.80% <100.00%> (+0.21%)`	⬆️
UI	`99.10% <100.00%> (+0.20%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6964b9...f4e33f8. Read the comment docs.

codecov · 2024-10-03T16:12:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (b6964b9) to head (f4e33f8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3349      +/-   ##
==========================================
+ Coverage   99.12%   99.17%   +0.04%     
==========================================
  Files         800      799       -1     
  Lines       14016    14093      +77     
  Branches     3856     3887      +31     
==========================================
+ Hits        13894    13977      +83     
+ Misses        113      107       -6     
  Partials        9        9

Files with missing lines	Coverage Δ
...ailPage/CommitCoverage/UploadsCard/RenderError.tsx	`100.00% <100.00%> (ø)`
...tailPage/CommitCoverage/UploadsCard/UploadItem.tsx	`100.00% <100.00%> (ø)`
...age/CommitCoverage/UploadsCard/UploadReference.tsx	`100.00% <100.00%> (ø)`
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	`100.00% <100.00%> (ø)`
...ommitCoverage/UploadsCard/useUploads/useUploads.ts	`100.00% <100.00%> (ø)`
src/services/commit/useCommit.tsx	`100.00% <100.00%> (ø)`
src/shared/utils/commit.ts	`100.00% <100.00%> (ø)`
src/shared/utils/extractUploads.ts	`100.00% <100.00%> (+6.38%)`	⬆️
src/ui/SearchField/SearchField.jsx	`100.00% <100.00%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.97% <100.00%> (+<0.01%)`	⬆️
Services	`99.44% <100.00%> (+<0.01%)`	⬆️
Shared	`99.80% <100.00%> (+0.21%)`	⬆️
UI	`99.10% <100.00%> (+0.20%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6964b9...f4e33f8. Read the comment docs.

codecov-staging · 2024-10-03T16:52:11Z

Bundle Report

Changes will increase total bundle size by 12.09kB (0.2%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-array-push	6.09MB	12.09kB (0.2%) ⬆️

codecov · 2024-10-03T16:52:44Z

Bundle Report

Changes will increase total bundle size by 12.09kB (0.2%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-array-push	6.09MB	12.09kB (0.2%) ⬆️

codecov-releaser · 2024-10-03T16:53:49Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`3bccf2e`	Thu, 03 Oct 2024 16:53:49 GMT	Expired	Expired
`aedadad`	Thu, 03 Oct 2024 17:07:21 GMT	Expired	Expired
`aedadad`	Thu, 03 Oct 2024 17:10:40 GMT	Expired	Expired
`b87a38e`	Thu, 03 Oct 2024 17:23:07 GMT	Expired	Expired
`700d9d3`	Thu, 03 Oct 2024 17:57:36 GMT	Expired	Expired
`2d6d9cf`	Fri, 04 Oct 2024 20:27:06 GMT	Expired	Expired
`fa96d59`	Fri, 04 Oct 2024 21:08:02 GMT	Expired	Expired
`f4e33f8`	Mon, 07 Oct 2024 14:25:32 GMT	Cloud	Enterprise

nicholas-codecov

Couple of comments to peak at

src/ui/Checkbox/CheckboxNew.tsx

src/shared/utils/extractUploads.ts

src/pages/CommitDetailPage/CommitCoverage/UploadsCard/UploadItem.test.tsx

src/pages/CommitDetailPage/CommitCoverage/UploadsCard/UploadItem.tsx

nicholas-codecov

Awesome work with those small fixes!

spalmurray-codecov marked this pull request as ready for review October 3, 2024 19:04

nicholas-codecov reviewed Oct 4, 2024

View reviewed changes

spalmurray-codecov added 10 commits October 4, 2024 14:25

Convert UploadsCard to Card component

867aaf1

Remove CheckboxNew accidentally left

628f543

Add search and filter to uploads list

634e431

Fix merge issue

26cbafc

Fix type error

7e369ca

Remove unnecessary line

2a00bd3

Hide filters if no relevant uploads

43f92e4

Remove parent div if no children

e573fe2

Fix spacing

a0475c8

Changes after Nick review

05b0979

spalmurray-codecov force-pushed the spalmrurray/upload-search-filter branch from 700d9d3 to 05b0979 Compare October 4, 2024 18:25

Fix type error

cf75070

nicholas-codecov approved these changes Oct 4, 2024

View reviewed changes

spalmurray-codecov added 4 commits October 4, 2024 16:19

Fix type errors

47f2499

Fix type errors

2d6d9cf

Fix test

fa96d59

Cover missing line

f4e33f8

spalmurray-codecov added this pull request to the merge queue Oct 7, 2024

Merged via the queue into main with commit b133ce8 Oct 7, 2024
62 checks passed

spalmurray-codecov deleted the spalmrurray/upload-search-filter branch October 7, 2024 14:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add search and filter to Uploads list #3349

feat: Add search and filter to Uploads list #3349

spalmurray-codecov commented Oct 3, 2024 •

edited

Loading

codecov-qa bot commented Oct 3, 2024 •

edited

Loading

codecov-public-qa bot commented Oct 3, 2024 •

edited

Loading

codecov-notifications bot commented Oct 3, 2024 •

edited

Loading

codecov bot commented Oct 3, 2024 •

edited

Loading

codecov-staging bot commented Oct 3, 2024 •

edited

Loading

codecov bot commented Oct 3, 2024 •

edited

Loading

codecov-releaser commented Oct 3, 2024 •

edited

Loading

nicholas-codecov left a comment

nicholas-codecov left a comment

feat: Add search and filter to Uploads list #3349

feat: Add search and filter to Uploads list #3349

Conversation

spalmurray-codecov commented Oct 3, 2024 • edited Loading

codecov-qa bot commented Oct 3, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Oct 3, 2024 • edited Loading

Codecov Report

codecov-notifications bot commented Oct 3, 2024 • edited Loading

Codecov Report

codecov bot commented Oct 3, 2024 • edited Loading

Codecov Report

codecov-staging bot commented Oct 3, 2024 • edited Loading

Bundle Report

codecov bot commented Oct 3, 2024 • edited Loading

Bundle Report

codecov-releaser commented Oct 3, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

nicholas-codecov left a comment

Choose a reason for hiding this comment

nicholas-codecov left a comment

Choose a reason for hiding this comment

spalmurray-codecov commented Oct 3, 2024 •

edited

Loading

codecov-qa bot commented Oct 3, 2024 •

edited

Loading

codecov-public-qa bot commented Oct 3, 2024 •

edited

Loading

codecov-notifications bot commented Oct 3, 2024 •

edited

Loading

codecov bot commented Oct 3, 2024 •

edited

Loading

codecov-staging bot commented Oct 3, 2024 •

edited

Loading

codecov bot commented Oct 3, 2024 •

edited

Loading

codecov-releaser commented Oct 3, 2024 •

edited

Loading