Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create new VirtualDiffRenderer #3352

Merged
merged 6 commits into from
Oct 4, 2024
Merged

feat: Create new VirtualDiffRenderer #3352

merged 6 commits into from
Oct 4, 2024

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Oct 4, 2024 •
edited
Loading

Description

This PR is the first in a handful for creating a diff renderer based off of the newer virtual file renderer.

Gonna do some further tidying up in a future PR.

Ticket: codecov/engineering-team#2590

Notable Changes

  • Create shared types, and consts
  • Move line number component into it's own file LineNumber
  • Create new VirtualDiffRenderer
  • Update VirtualFileRenderer to use LineNumber component

Screenshots

Screenshot 2024-10-04 at 09 50 44

Screenshot 2024-10-04 at 09 59 56

Screen.Recording.2024-10-04.at.09.48.38.mov

@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.35897% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.12%. Comparing base (fbe05b4) to head (a05481a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/ui/VirtualFileRenderer/VirtualDiffRenderer.tsx 99.26% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #3352    +/-   ##
========================================
  Coverage   99.12%   99.12%            
========================================
  Files         797      800     +3     
  Lines       13877    14016   +139     
  Branches     3817     3851    +34     
========================================
+ Hits        13756    13894   +138     
- Misses        112      113     +1     
  Partials        9        9
Files with missing lines Coverage Δ
src/ui/VirtualFileRenderer/ColorBar.tsx 100.00% <100.00%> (ø)
src/ui/VirtualFileRenderer/LineNumber.tsx 100.00% <100.00%> (ø)
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.00% <ø> (-0.11%) ⬇️
src/ui/VirtualFileRenderer/constants.ts 100.00% <100.00%> (ø)
src/ui/VirtualFileRenderer/VirtualDiffRenderer.tsx 99.26% <99.26%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.96% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.59% <ø> (ø)
UI 98.89% <99.35%> (+0.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe05b4...a05481a. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.35897% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.12%. Comparing base (fbe05b4) to head (a05481a).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #3352    +/-   ##
========================================
  Coverage   99.12%   99.12%            
========================================
  Files         797      800     +3     
  Lines       13877    14016   +139     
  Branches     3822     3856    +34     
========================================
+ Hits        13756    13894   +138     
- Misses        112      113     +1     
  Partials        9        9
Files Coverage Δ
src/ui/VirtualFileRenderer/ColorBar.tsx 100.00% <100.00%> (ø)
src/ui/VirtualFileRenderer/LineNumber.tsx 100.00% <100.00%> (ø)
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.00% <ø> (-0.11%) ⬇️
src/ui/VirtualFileRenderer/constants.ts 100.00% <100.00%> (ø)
src/ui/VirtualFileRenderer/VirtualDiffRenderer.tsx 99.26% <99.26%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.96% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.59% <ø> (ø)
UI 98.89% <99.35%> (+0.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe05b4...a05481a. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024

Bundle Report

Changes will increase total bundle size by 7.03kB (0.12%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.08MB 7.03kB (0.12%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.35897% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.12%. Comparing base (fbe05b4) to head (a05481a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/ui/VirtualFileRenderer/VirtualDiffRenderer.tsx 99.26% 1 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #3352    +/-   ##
========================================
  Coverage   99.12%   99.12%            
========================================
  Files         797      800     +3     
  Lines       13877    14016   +139     
  Branches     3822     3856    +34     
========================================
+ Hits        13756    13894   +138     
- Misses        112      113     +1     
  Partials        9        9
Files with missing lines Coverage Δ
src/ui/VirtualFileRenderer/ColorBar.tsx 100.00% <100.00%> (ø)
src/ui/VirtualFileRenderer/LineNumber.tsx 100.00% <100.00%> (ø)
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.00% <ø> (-0.11%) ⬇️
src/ui/VirtualFileRenderer/constants.ts 100.00% <100.00%> (ø)
src/ui/VirtualFileRenderer/VirtualDiffRenderer.tsx 99.26% <99.26%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.96% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.59% <ø> (ø)
UI 98.89% <99.35%> (+0.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe05b4...a05481a. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Oct 4, 2024 •
edited by codecov-notifications bot
Loading

Codecov Report

Attention: Patch coverage is 99.35897% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/ui/VirtualFileRenderer/VirtualDiffRenderer.tsx 99.26% 1 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #3352    +/-   ##
========================================
  Coverage   99.12%   99.12%            
========================================
  Files         797      800     +3     
  Lines       13877    14016   +139     
  Branches     3817     3851    +34     
========================================
+ Hits        13756    13894   +138     
- Misses        112      113     +1     
  Partials        9        9
Files with missing lines Coverage Δ
src/ui/VirtualFileRenderer/ColorBar.tsx 100.00% <100.00%> (ø)
src/ui/VirtualFileRenderer/LineNumber.tsx 100.00% <100.00%> (ø)
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.00% <ø> (-0.11%) ⬇️
src/ui/VirtualFileRenderer/constants.ts 100.00% <100.00%> (ø)
src/ui/VirtualFileRenderer/VirtualDiffRenderer.tsx 99.26% <99.26%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.96% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.59% <ø> (ø)
UI 98.89% <99.35%> (+0.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe05b4...a05481a. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
a05481a Fri, 04 Oct 2024 14:44:36 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit b6964b9 Oct 4, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2590-create-new-virtual-diff-viewer branch October 4, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov spalmurray-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @spalmurray-codecov