feat: Tokenless banners #3358
feat: Tokenless banners #3358
Conversation
Bundle ReportChanges will decrease total bundle size by 2.12kB (-0.03%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3358 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 799 802 +3
Lines 14105 14139 +34
Branches 3891 3896 +5
=======================================
+ Hits 13988 14022 +34
Misses 108 108
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3358 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 799 802 +3
Lines 14105 14139 +34
Branches 3886 3901 +15
=======================================
+ Hits 13988 14022 +34
Misses 108 108
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3358 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 799 802 +3
Lines 14105 14139 +34
Branches 3891 3901 +10
=======================================
+ Hits 13988 14022 +34
Misses 108 108
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3358 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 799 802 +3
Lines 14105 14139 +34
Branches 3886 3896 +10
=======================================
+ Hits 13988 14022 +34
Misses 108 108
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Bundle ReportChanges will decrease total bundle size by 2.12kB (-0.03%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
| }) | ||
|
|
||
| describe('unsuccessful parse of zod schema', () => { | ||
| beforeEach(() => { |
There was a problem hiding this comment.
nit: this and the other could be "beforeAll" and "afterAll."
| {typeof orgUploadToken === 'string' ? ( | ||
| <OrgUploadTokenTooltip orgUploadToken={orgUploadToken} /> | ||
| ) : ( | ||
| 'the global upload token ' |
There was a problem hiding this comment.
weird how it says this line is uncovered when you specifically have a test for it 🤔
There was a problem hiding this comment.
it's been acting up like that lately i posted about it got no help :"D
Description
This updates tokeneless banners to display:
Notable Changes
Screenshots
Link to Sample Entry
Design: https://www.figma.com/design/CRM2ODN4ihBWITjC3xryF1/GH-2100?node-id=1-2&node-type=canvas&t=1YFaoET5ZEuqBoB4-0
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.