Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove virtual diff feature flag from commits indirect changes diff #3448

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Oct 29, 2024

Description

This PR updates/refactors the indirect changes CommitFileDiff to TS and removes the virtual diff feature flag

Closes codecov/engineering-team#2730

Notable Changes

  • Update/Refactor CommitFileDiff
  • Update/Refactor tests

@nicholas-codecov nicholas-codecov changed the title chore: Remove virtual feature flag from commits indirect changes diff chore: Remove virtual diff feature flag from commits indirect changes diff Oct 29, 2024
@codecov-staging
Copy link

codecov-staging bot commented Oct 29, 2024

Bundle Report

Changes will decrease total bundle size by 2.58kB (-0.02%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.55MB 1.08kB (-0.02%) ⬇️
gazebo-staging-system 5.5MB 1.5kB (-0.03%) ⬇️

Copy link

codecov bot commented Oct 29, 2024

Bundle Report

Changes will decrease total bundle size by 2.58kB (-0.02%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.5MB 1.5kB (-0.03%) ⬇️
gazebo-production-system-esm 5.55MB 1.08kB (-0.02%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.14%. Comparing base (730e89f) to head (ef31a9f).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx 97.67% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3448      +/-   ##
==========================================
- Coverage   99.15%   99.14%   -0.01%     
==========================================
  Files         809      809              
  Lines       14297    14303       +6     
  Branches     3949     3949              
==========================================
+ Hits        14176    14181       +5     
- Misses        112      113       +1     
  Partials        9        9              
Files with missing lines Coverage Δ
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx 97.67% <97.67%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.87% <97.67%> (-0.02%) ⬇️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730e89f...ef31a9f. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx 97.67% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3448      +/-   ##
==========================================
- Coverage   99.15%   99.14%   -0.01%     
==========================================
  Files         809      809              
  Lines       14297    14303       +6     
  Branches     3956     3956              
==========================================
+ Hits        14176    14181       +5     
- Misses        112      113       +1     
  Partials        9        9              
Files with missing lines Coverage Δ
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx 97.67% <97.67%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.87% <97.67%> (-0.02%) ⬇️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730e89f...ef31a9f. Read the comment docs.

Copy link

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.14%. Comparing base (730e89f) to head (ef31a9f).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3448      +/-   ##
==========================================
- Coverage   99.15%   99.14%   -0.01%     
==========================================
  Files         809      809              
  Lines       14297    14303       +6     
  Branches     3949     3956       +7     
==========================================
+ Hits        14176    14181       +5     
- Misses        112      113       +1     
  Partials        9        9              
Files Coverage Δ
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx 97.67% <97.67%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.87% <97.67%> (-0.02%) ⬇️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730e89f...ef31a9f. Read the comment docs.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.14%. Comparing base (730e89f) to head (ef31a9f).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx 97.67% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3448      +/-   ##
==========================================
- Coverage   99.15%   99.14%   -0.01%     
==========================================
  Files         809      809              
  Lines       14297    14303       +6     
  Branches     3956     3956              
==========================================
+ Hits        14176    14181       +5     
- Misses        112      113       +1     
  Partials        9        9              
Files with missing lines Coverage Δ
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx 97.67% <97.67%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.87% <97.67%> (-0.02%) ⬇️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730e89f...ef31a9f. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
ef31a9f Tue, 29 Oct 2024 18:17:18 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 1641fbb Oct 30, 2024
54 of 62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2728-chore-remove-virtual-feature-flag-from-commits-indirect-changes-diff branch October 30, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Remove VirtualDiffRenderer from IndirectChanges CommitFileDiff
3 participants