Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Responsiveness tweaks for TA Selector section #3472

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Nov 7, 2024

Description

This PR aims to fix some responsiveness issues that occurred when on some smaller screen sizes on the Test Analytics page.

Screenshots

Screen.Recording.2024-11-07.at.11.29.51.AM.mov
Screenshot 2024-11-08 at 9 33 23 AM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (c5a9d52) to head (470858d).
Report is 2 commits behind head on tests-analytics-v2.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           tests-analytics-v2    #3472   +/-   ##
===================================================
  Coverage               99.02%   99.02%           
===================================================
  Files                     813      813           
  Lines                   14395    14395           
  Branches                 4057     4057           
===================================================
  Hits                    14255    14255           
  Misses                    131      131           
  Partials                    9        9           
Files with missing lines Coverage Δ
.../SelectorSection/BranchSelector/BranchSelector.tsx 100.00% <ø> (ø)
...ailedTestsPage/SelectorSection/SelectorSection.tsx 95.74% <ø> (ø)
...stsTab/FailedTestsPage/TableHeader/TableHeader.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.68% <ø> (ø)
Services 99.42% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a9d52...470858d. Read the comment docs.

Copy link

codecov-public-qa bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (c5a9d52) to head (470858d).
Report is 1 commits behind head on tests-analytics-v2.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           tests-analytics-v2    #3472   +/-   ##
===================================================
  Coverage               99.02%   99.02%           
===================================================
  Files                     813      813           
  Lines                   14395    14395           
  Branches                 4050     4050           
===================================================
  Hits                    14255    14255           
  Misses                    131      131           
  Partials                    9        9           
Files Coverage Δ
.../SelectorSection/BranchSelector/BranchSelector.tsx 100.00% <ø> (ø)
...ailedTestsPage/SelectorSection/SelectorSection.tsx 95.74% <ø> (ø)
...stsTab/FailedTestsPage/TableHeader/TableHeader.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.68% <ø> (ø)
Services 99.42% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a9d52...470858d. Read the comment docs.

Copy link

codecov bot commented Nov 7, 2024

Bundle Report

Changes will increase total bundle size by 437 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.77MB 128 bytes (0.0%) ⬆️
gazebo-production-system-esm 5.82MB 309 bytes (0.01%) ⬆️

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (c5a9d52) to head (da14b1d).
Report is 1 commits behind head on tests-analytics-v2.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           tests-analytics-v2    #3472   +/-   ##
===================================================
  Coverage               99.02%   99.02%           
===================================================
  Files                     813      813           
  Lines                   14395    14395           
  Branches                 4050     4050           
===================================================
  Hits                    14255    14255           
  Misses                    131      131           
  Partials                    9        9           
Files with missing lines Coverage Δ
.../SelectorSection/BranchSelector/BranchSelector.tsx 100.00% <ø> (ø)
...ailedTestsPage/SelectorSection/SelectorSection.tsx 95.74% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.68% <ø> (ø)
Services 99.42% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a9d52...da14b1d. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           tests-analytics-v2    #3472   +/-   ##
===================================================
  Coverage               99.02%   99.02%           
===================================================
  Files                     813      813           
  Lines                   14395    14395           
  Branches                 4050     4050           
===================================================
  Hits                    14255    14255           
  Misses                    131      131           
  Partials                    9        9           
Files with missing lines Coverage Δ
.../SelectorSection/BranchSelector/BranchSelector.tsx 100.00% <ø> (ø)
...ailedTestsPage/SelectorSection/SelectorSection.tsx 95.74% <ø> (ø)
...stsTab/FailedTestsPage/TableHeader/TableHeader.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.68% <ø> (ø)
Services 99.42% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a9d52...470858d. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 7, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
da14b1d Thu, 07 Nov 2024 19:38:12 GMT Expired Expired
470858d Fri, 08 Nov 2024 17:39:00 GMT Cloud Enterprise

@nicholas-codecov
Copy link
Contributor

nicholas-codecov commented Nov 7, 2024

Hrmrm, some of these test path names are pushing the select box out far enough that it's pushing width too far breaking things, i wonder if vertically stacking the selects could help a bit with this 🤔

Screenshot 2024-11-07 at 15 40 36

@ajay-sentry
Copy link
Contributor Author

Hrmrm, some of these test path names are pushing the select box out far enough that it's pushing width too far breaking things, i wonder if vertically stacking the selects could help a bit with this 🤔

Screenshot 2024-11-07 at 15 40 36

If we want to loop in design for a Mobile iteration that could be a worthwhile pursuit after we go live. For now I think we can treat that as a nit

@nicholas-codecov
Copy link
Contributor

If we want to loop in design for a Mobile iteration that could be a worthwhile pursuit after we go live. For now I think we can treat that as a nit

This is a screenshot from my Macbook's screen, and it breaking the styling:

Screenshot 2024-11-08 at 07 55 36

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 437 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.82MB 309 bytes (0.01%) ⬆️
gazebo-staging-system 5.77MB 128 bytes (0.0%) ⬆️

@ajay-sentry ajay-sentry merged commit 1f648aa into tests-analytics-v2 Nov 8, 2024
58 of 59 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/ta-responsiveness-tweaks branch November 8, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants