refactor: Convert UI files to TS #3475
Conversation
| { | ||
| [buttonVariant.outlined]: | ||
| 'ring-1 ring-inset ring-gray-300 focus:ring-2 focus:ring-indigo-600 shadow-sm', | ||
| } |
There was a problem hiding this comment.
this seemed like a bug... with cs, if we pass an obj, it applies the key as the class string if the value is truthy. Which means this was always just adding the classname "undefined"
Bundle ReportChanges will increase total bundle size by 20.74kB (0.12%) ⬆️. This is within the configured threshold ✅ Detailed changes
ℹ️ *Bundle size includes cached data from a previous commit |
Bundle ReportChanges will increase total bundle size by 45.26kB (0.26%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3475 +/- ##
==========================================
- Coverage 99.17% 99.09% -0.09%
==========================================
Files 800 808 +8
Lines 14132 14399 +267
Branches 4001 4102 +101
==========================================
+ Hits 14015 14268 +253
- Misses 110 124 +14
Partials 7 7
... and 18 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3475 +/- ##
==========================================
- Coverage 99.17% 99.09% -0.09%
==========================================
Files 800 808 +8
Lines 14132 14399 +267
Branches 4008 4095 +87
==========================================
+ Hits 14015 14268 +253
- Misses 110 124 +14
Partials 7 7
... and 18 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3475 +/- ##
==========================================
- Coverage 99.17% 99.09% -0.09%
==========================================
Files 800 808 +8
Lines 14132 14399 +267
Branches 4001 4095 +94
==========================================
+ Hits 14015 14268 +253
- Misses 110 124 +14
Partials 7 7
... and 18 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3475 +/- ##
==========================================
- Coverage 99.17% 99.09% -0.09%
==========================================
Files 800 808 +8
Lines 14132 14399 +267
Branches 4008 4102 +94
==========================================
+ Hits 14015 14268 +253
- Misses 110 124 +14
Partials 7 7
... and 18 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
| interface WithTo { | ||
| to: AppLinkProps | ||
| hook?: string | ||
| } | ||
| interface WithoutTo { | ||
| to?: never | ||
| hook: string | ||
| } |
There was a problem hiding this comment.
this replaces the validation function for hook from the PropTypes
| type ExtendedButtonProps = ButtonProps & | ||
| (WithTo | WithoutTo) & | ||
| Partial<AppLinkProps> |
There was a problem hiding this comment.
Button essentially has to shepherd along props to possible AppLink render
calvin-codecov
changed the title
Description
Closes codecov/engineering-team#2724
Notable Changes
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.