Add java support #7
Conversation
|
@rohitpaulk any updates? |
|
This should be done today! Ref: codecrafters-io/build-your-own-http-server#17 (comment) |
|
@urielsalis I pushed a couple of changes related to compiling templates, but looks like the starter code is failing tests: 
Could you try to get the tests working? You'll find instructions on how to execute them in the readme here: https://github.com/codecrafters-io/course-sdk |
|
@urielsalis We're also working on a way to make course-sdk easier to use, which should be ready mid next-week. That should make the whole language support experience more user-friendly. I'll wait for that to land before looking at the other PRs, linking them here so that the github timeline links here: |
|
@rohitpaulk I was missing the dest address. It should work now. |
Works with course-sdk!
|
|
And I made sure to run the same in all the other PRs :D |
|
@urielsalis awesome! Added the Java guide here: https://docs.codecrafters.io/challenges/language-support/java. Will quickly test this against the new course-sdk we're working on and hoping to merge tomorrow! |
|
Looks good! Might be worth adding a link to Intellij Community edition (same as for Kotlin). Makes Java way more begginer friendly than the vscode plugins |
@rohitpaulk did this myself just now and all of them, including sqlite which didnt work with the previous sdk, seem to work! |
We only finished implementing the rest of the tests today, so it's likely that all tests weren't running when you ran against the new SDK 😅 If you install it again now, proper tests should be run. |
|
This is looking good! Works against the new course-sdk too. Pushed one small commit, GitHub seems to be taking a while to recognize it... |
|
Ah, looks like a github incident: https://www.githubstatus.com/incidents/66vhjmd266r9 |
No description provided.