Skip to content

Commit

Permalink
Merge pull request #68 from codecrafters-io/fix-double-uncomment
Browse files Browse the repository at this point in the history
fix double uncomment
  • Loading branch information
rohitpaulk authored Aug 27, 2024
2 parents 7f7832e + 19260c9 commit 29ed7d8
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 18 deletions.
9 changes: 6 additions & 3 deletions compiled_starters/go/app/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@ package main

import (
"fmt"
// Uncomment this block to pass the first stage!
// "os"
// "os/exec"
"os"
"os/exec"
)

// Ensures gofmt doesn't remove the imports above (feel free to remove this!)
var _ = os.Args
var _ = exec.Command

// Usage: your_docker.sh run <image> <command> <arg1> <arg2> ...
func main() {
// You can use print statements as follows for debugging, they'll be visible when running tests.
Expand Down
4 changes: 4 additions & 0 deletions solutions/go/01-je9/code/app/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ import (
"os/exec"
)

// Ensures gofmt doesn't remove the imports above (feel free to remove this!)
var _ = os.Args
var _ = exec.Command

// Usage: your_docker.sh run <image> <command> <arg1> <arg2> ...
func main() {
command := os.Args[3]
Expand Down
13 changes: 7 additions & 6 deletions solutions/go/01-je9/diff/app/main.go.diff
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
@@ -1,28 +1,22 @@
@@ -1,31 +1,26 @@
package main

import (
"fmt"
- // Uncomment this block to pass the first stage!
- // "os"
- // "os/exec"
+ "os"
+ "os/exec"
"os"
"os/exec"
)

// Ensures gofmt doesn't remove the imports above (feel free to remove this!)
var _ = os.Args
var _ = exec.Command

// Usage: your_docker.sh run <image> <command> <arg1> <arg2> ...
func main() {
- // You can use print statements as follows for debugging, they'll be visible when running tests.
Expand Down
6 changes: 0 additions & 6 deletions solutions/go/01-je9/explanation.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@ The entry point for your Docker implementation is in `app/main.go`.

Study and uncomment the relevant code:

```go
// Uncomment this block to pass the first stage!
"os"
"os/exec"
```

```go
// Uncomment this block to pass the first stage!

Expand Down
9 changes: 6 additions & 3 deletions starter_templates/go/code/app/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@ package main

import (
"fmt"
// Uncomment this block to pass the first stage!
// "os"
// "os/exec"
"os"
"os/exec"
)

// Ensures gofmt doesn't remove the imports above (feel free to remove this!)
var _ = os.Args
var _ = exec.Command

// Usage: your_docker.sh run <image> <command> <arg1> <arg2> ...
func main() {
// You can use print statements as follows for debugging, they'll be visible when running tests.
Expand Down

0 comments on commit 29ed7d8

Please sign in to comment.