New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CC-804 test new ci for docker #37

Closed

libmartinito wants to merge 1 commit into main from test-updated-ci-for-files

Contributor

libmartinito commented Nov 4, 2023

No description provided.


          test

3bf88ad

linear bot commented Nov 4, 2023

CC-804 Add CI check for no changed files after build

We add .gitignore files to ensure that when a user first runs their code, there aren't any extra changes or files added.

I had to manually add one after realizing that we missed adding .gitignore for one repository: codecrafters-io/build-your-own-bittorrent@c08ac1f.

Let's add a CI check that checks for this. We already have one that does this during compilation: https://github.com/codecrafters-io/course-sdk/blob/7207a820a9cae5f2a418ddd534841d4a2ac1acd6/.github/workflows/test-course-definition.yml#L48-L54, let's add similar checks that run after we run stage 1. I think that'd be somewhere here: https://github.com/codecrafters-io/course-sdk/blob/7207a820a9cae5f2a418ddd534841d4a2ac1acd6/lib/starter_repo_tester.rb#L41.

libmartinito closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet