Skip to content

Commit

Permalink
Merge pull request #92 from codecrafters-io/remove-copy-app
Browse files Browse the repository at this point in the history
remove COPY app instruction
  • Loading branch information
rohitpaulk authored Aug 14, 2024
2 parents 79fc1f5 + db10bb5 commit e2a0a2f
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 16 deletions.
3 changes: 0 additions & 3 deletions dockerfiles/cpp-23.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,3 @@ RUN if [ -d "/app/vcpkg_installed" ]; then mv /app/vcpkg_installed /app-cached/b

RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && cmake -B build -S . -DCMAKE_TOOLCHAIN_FILE=${VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake && cmake --build ./build && sed -i '/^cmake/ s/^/# /' ./your_grep.sh" > /codecrafters-precompile.sh
RUN chmod +x /codecrafters-precompile.sh

# Once the heavy steps are done, we can copy all files back
COPY . /app
3 changes: 0 additions & 3 deletions dockerfiles/gleam-1.4.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,3 @@ RUN gleam build
# Cache build directory
RUN mkdir -p /app-cached
RUN mv build /app-cached/build

# Once the heavy steps are done, we can copy all files back
COPY . /app
3 changes: 0 additions & 3 deletions dockerfiles/kotlin-2.0.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,3 @@ COPY --exclude=.git --exclude=README.md . /app

# Cache dependencies
RUN mvn -B package -Ddir=/tmp/codecrafters-build-grep-kotlin

# Once the heavy steps are done, we can copy all files back
COPY . /app
1 change: 0 additions & 1 deletion dockerfiles/rust-1.62.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && cargo build --release --target-d
RUN chmod +x /codecrafters-precompile.sh

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

1 change: 0 additions & 1 deletion dockerfiles/rust-1.68.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && cargo build --release --target-d
RUN chmod +x /codecrafters-precompile.sh

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

1 change: 0 additions & 1 deletion dockerfiles/rust-1.70.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && cargo build --release --target-d
RUN chmod +x /codecrafters-precompile.sh

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

1 change: 0 additions & 1 deletion dockerfiles/rust-1.76.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && cargo build --release --target-d
RUN chmod +x /codecrafters-precompile.sh

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

3 changes: 0 additions & 3 deletions dockerfiles/rust-1.77.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,3 @@ RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && cargo build --release --target-d
RUN chmod +x /codecrafters-precompile.sh

ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="Cargo.toml,Cargo.lock"

# Once the heavy steps are done, we can copy all files back
COPY . /app

0 comments on commit e2a0a2f

Please sign in to comment.