Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CC-834 changed -E to -P #51

Closed
wants to merge 1 commit into from
Closed

CC-834 changed -E to -P #51

wants to merge 1 commit into from

Conversation

libmartinito
Copy link
Contributor

@libmartinito libmartinito commented Nov 28, 2023 •
edited
Loading

the purpose of this change is to keep consistency.
ripgrep requires the '-P' flag to enable support for backreferences.
more details here

@linear Linear
Copy link

linear bot commented Nov 28, 2023

CC-834 Ship grep backreferences extension

https://codecrafters.slab.com/posts/grep-backreferences-extension-tb6854ip

@rohitpaulk
Copy link
Member

We decided to not do this and instead mangle the your_grep.sh script used in the tester's tests

@rohitpaulk rohitpaulk closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitpaulk rohitpaulk Awaiting requested review from rohitpaulk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@libmartinito @rohitpaulk