Merge pull request #264 from codecrafters-io/update-bun-buildpack

CC-1438: Update bun buildpack
codecrafters-io · Oct 1, 2024 · 4765ff3 · 4765ff3
2 parents 5cc0c06 + b174eec
commit 4765ff3
Show file tree

Hide file tree

Showing 10 changed files with 86 additions and 43 deletions.
diff --git a/compiled_starters/typescript/bun.lockb b/compiled_starters/typescript/bun.lockb
diff --git a/compiled_starters/typescript/package.json b/compiled_starters/typescript/package.json
@@ -9,6 +9,6 @@
     "async": "^3.2.0"
   },
   "devDependencies": {
-    "@types/node": "^20.12.11"
+    "@types/bun": "latest"
   }
 }
diff --git a/compiled_starters/typescript/tsconfig.json b/compiled_starters/typescript/tsconfig.json
@@ -1,13 +1,27 @@
 {
-    "compilerOptions": {
-        "target": "ES2020",
-        "module": "ES2020",
-        "moduleResolution": "node",
-        "esModuleInterop": true,
-        "strict": true,
-        "skipLibCheck": true,
-    },
-    "ts-node": {
-        "esm": true
-    }
-}
+  "compilerOptions": {
+    // Enable latest features
+    "lib": ["ESNext", "DOM"],
+    "target": "ESNext",
+    "module": "ESNext",
+    "moduleDetection": "force",
+    "jsx": "react-jsx",
+    "allowJs": true,
+
+    // Bundler mode
+    "moduleResolution": "bundler",
+    "allowImportingTsExtensions": true,
+    "verbatimModuleSyntax": true,
+    "noEmit": true,
+
+    // Best practices
+    "strict": true,
+    "skipLibCheck": true,
+    "noFallthroughCasesInSwitch": true,
+
+    // Some stricter flags (disabled by default)
+    "noUnusedLocals": false,
+    "noUnusedParameters": false,
+    "noPropertyAccessFromIndexSignature": false
+  }
+}
diff --git a/dockerfiles/bun-1.1.Dockerfile b/dockerfiles/bun-1.1.Dockerfile
@@ -1,17 +1,18 @@
-FROM oven/bun:1.1.4-alpine
+# syntax=docker/dockerfile:1.7-labs
+FROM oven/bun:1.1-alpine
 
 ENV CODECRAFTERS_DEPENDENCY_FILE_PATHS="package.json,bun.lockb"
 
 WORKDIR /app
 
-COPY package.json ./
-COPY bun.lockb ./
+# .git & README.md are unique per-repository. We ignore them on first copy to prevent cache misses
+COPY --exclude=.git --exclude=README.md . /app
 
 # For reproducible builds.
 # This will install the exact versions of each package specified in the lockfile.
 # If package.json disagrees with bun.lockb, Bun will exit with an error. The lockfile will not be updated.
 RUN bun install --frozen-lockfile
 
-RUN mkdir -p /app-cached
 # If the node_modules directory exists, move it to /app-cached
+RUN mkdir -p /app-cached
 RUN if [ -d "/app/node_modules" ]; then mv /app/node_modules /app-cached; fi
diff --git a/solutions/typescript/01-jm1/code/bun.lockb b/solutions/typescript/01-jm1/code/bun.lockb
diff --git a/solutions/typescript/01-jm1/code/package.json b/solutions/typescript/01-jm1/code/package.json
@@ -9,6 +9,6 @@
     "async": "^3.2.0"
   },
   "devDependencies": {
-    "@types/node": "^20.12.11"
+    "@types/bun": "latest"
   }
 }
diff --git a/solutions/typescript/01-jm1/code/tsconfig.json b/solutions/typescript/01-jm1/code/tsconfig.json
@@ -1,13 +1,27 @@
 {
-    "compilerOptions": {
-        "target": "ES2020",
-        "module": "ES2020",
-        "moduleResolution": "node",
-        "esModuleInterop": true,
-        "strict": true,
-        "skipLibCheck": true,
-    },
-    "ts-node": {
-        "esm": true
-    }
-}
+  "compilerOptions": {
+    // Enable latest features
+    "lib": ["ESNext", "DOM"],
+    "target": "ESNext",
+    "module": "ESNext",
+    "moduleDetection": "force",
+    "jsx": "react-jsx",
+    "allowJs": true,
+
+    // Bundler mode
+    "moduleResolution": "bundler",
+    "allowImportingTsExtensions": true,
+    "verbatimModuleSyntax": true,
+    "noEmit": true,
+
+    // Best practices
+    "strict": true,
+    "skipLibCheck": true,
+    "noFallthroughCasesInSwitch": true,
+
+    // Some stricter flags (disabled by default)
+    "noUnusedLocals": false,
+    "noUnusedParameters": false,
+    "noPropertyAccessFromIndexSignature": false
+  }
+}
diff --git a/starter_templates/typescript/code/bun.lockb b/starter_templates/typescript/code/bun.lockb
diff --git a/starter_templates/typescript/code/package.json b/starter_templates/typescript/code/package.json
@@ -9,6 +9,6 @@
     "async": "^3.2.0"
   },
   "devDependencies": {
-    "@types/node": "^20.12.11"
+    "@types/bun": "latest"
   }
 }
diff --git a/starter_templates/typescript/code/tsconfig.json b/starter_templates/typescript/code/tsconfig.json
@@ -1,13 +1,27 @@
 {
-    "compilerOptions": {
-        "target": "ES2020",
-        "module": "ES2020",
-        "moduleResolution": "node",
-        "esModuleInterop": true,
-        "strict": true,
-        "skipLibCheck": true,
-    },
-    "ts-node": {
-        "esm": true
-    }
-}
+  "compilerOptions": {
+    // Enable latest features
+    "lib": ["ESNext", "DOM"],
+    "target": "ESNext",
+    "module": "ESNext",
+    "moduleDetection": "force",
+    "jsx": "react-jsx",
+    "allowJs": true,
+
+    // Bundler mode
+    "moduleResolution": "bundler",
+    "allowImportingTsExtensions": true,
+    "verbatimModuleSyntax": true,
+    "noEmit": true,
+
+    // Best practices
+    "strict": true,
+    "skipLibCheck": true,
+    "noFallthroughCasesInSwitch": true,
+
+    // Some stricter flags (disabled by default)
+    "noUnusedLocals": false,
+    "noUnusedParameters": false,
+    "noPropertyAccessFromIndexSignature": false
+  }
+}