Skip to content

Commit

Permalink
Merge pull request #284 from codecrafters-io/andy/patch
Browse files Browse the repository at this point in the history
[php] Delete closing ?>
  • Loading branch information
andy1li authored Dec 12, 2024
2 parents dc61800 + 327c528 commit 47c9e38
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 5 deletions.
1 change: 0 additions & 1 deletion compiled_starters/php/app/main.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,3 @@
// socket_accept($sock); // Wait for first client

// socket_close($sock);
?>
1 change: 0 additions & 1 deletion solutions/php/01-jm1/code/app/main.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,3 @@
socket_accept($sock); // Wait for first client

// socket_close($sock);
?>
3 changes: 1 addition & 2 deletions solutions/php/01-jm1/diff/app/main.php.diff
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@@ -1,17 +1,13 @@
@@ -1,16 +1,12 @@
<?php
error_reporting(E_ALL);

Expand All @@ -22,4 +22,3 @@
+socket_accept($sock); // Wait for first client

// socket_close($sock);
?>
1 change: 0 additions & 1 deletion starter_templates/php/code/app/main.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,3 @@
// socket_accept($sock); // Wait for first client

// socket_close($sock);
?>

0 comments on commit 47c9e38

Please sign in to comment.